Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow re-use of an existing audio sink. #12035

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −2
Draft

Allow re-use of an existing audio sink. #12035

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e6acc3
Update sinks.rs
AxiomaticSemantics Feb 22, 2024
b1ec535
Update sinks.rs
AxiomaticSemantics Feb 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/bevy_audio/src/sinks.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ pub trait AudioSinkPlayback {
/// that source is unchanged, that translates to the audio restarting.
#[derive(Component)]
pub struct AudioSink {
pub(crate) sink: Sink,
pub sink: Sink,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc strings for these fields now that they're pub.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya sorry this should be draft still

}

impl AudioSinkPlayback for AudioSink {
Expand Down Expand Up @@ -138,7 +138,7 @@ impl AudioSinkPlayback for AudioSink {
/// that source is unchanged, that translates to the audio restarting.
#[derive(Component)]
pub struct SpatialAudioSink {
pub(crate) sink: SpatialSink,
pub sink: SpatialSink,
}

impl AudioSinkPlayback for SpatialAudioSink {
Expand Down
Loading