Stop copying the light probe array to the stack in the shader. #11805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing a severe performance regression when light probes were enabled.
JMS55
added
A-Rendering
|
seems fix #11787 |
|
This really needs to get in for 0.13. |
JMS55
approved these changes
Feb 10, 2024
Elabajaba
approved these changes
Feb 10, 2024
There was a problem hiding this comment.
Code seems fine. The comment for is_irradiance_volume is a bit ugly, but that's just nitpicking.
I'm still seeing a (significantly smaller) 5-10% regression at 4k (GPU timing for the Opaque3d pass, tested on bistro and synty castle scene on my 6800xt with locked clocks), but at 1080p this seems to have brought performance to the same as before irradiance volumes were merged.
alice-i-cecile
added
the
S-Ready-For-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing a severe performance regression when light probes were enabled.
Fixes #11787.