Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

example showcase: fix window resized patch #11596

Merged
merged 1 commit into from
Jan 29, 2024
Merged

example showcase: fix window resized patch #11596

merged 1 commit into from
Jan 29, 2024

Conversation

mockersf
Copy link
Member

Objective

  • one of the patch for the example showcase need to be updated after the recent winit event loop changes

Solution

  • update it

@mockersf mockersf added the A-Build-System Related to build systems or continuous integration label Jan 29, 2024
nicopap
nicopap approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@nicopap nicopap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My fault 😅 LGTM

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 29, 2024
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jan 29, 2024
Merged via the queue into bevyengine:main with commit ba2fffe Jan 29, 2024
25 checks passed
tjamaan pushed a commit to tjamaan/bevy that referenced this pull request Feb 6, 2024
@mockersf @tjamaan
example showcase: fix window resized patch (bevyengine#11596)
03fe127 
# Objective

- one of the patch for the example showcase need to be updated after the
recent winit event loop changes

## Solution

- update it
@rparrett rparrett mentioned this pull request Mar 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicopap nicopap nicopap approved these changes

@doonv doonv doonv approved these changes

Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mockersf @nicopap @doonv @alice-i-cecile