CameraProjection::compute_frustum #11139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
A-Rendering
stepancheg
force-pushed
the
compute-frustum
branch
from
45bb3f3
to
7a8fa67
Compare
atlv24
approved these changes
Jan 15, 2024
Co-authored-by: vero <[email protected]>
jdm
approved these changes
Jan 28, 2024
james7132
approved these changes
Feb 4, 2024
tjamaan
pushed a commit
to tjamaan/bevy
that referenced
this pull request
Feb 6, 2024
Frustum computation is nontrivial amount of code private in `update_frusta` system. Make it public. This is needed to decide which entities to spawn/despawn in `Update` based on camera changes. But if `Update` also changed camera, frustum is not yet recomputed. Technically it is probably possible to run an iteration of `update_frusta` system by a user in `Update` schedule after propagating `GlobalTransform` to the cameras, but it is easier to just compute frustum manually using API added in this PR. Also replace two places where this code is used. --------- Co-authored-by: vero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frustum computation is nontrivial amount of code private in
update_frustasystem.Make it public.
This is needed to decide which entities to spawn/despawn in
Updatebased on camera changes. But ifUpdatealso changed camera, frustum is not yet recomputed.Technically it is probably possible to run an iteration of
update_frustasystem by a user inUpdateschedule after propagatingGlobalTransformto the cameras, but it is easier to just compute frustum manually using API added in this PR.Also replace two places where this code is used.