Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use WindowBuilder::with_append() to append canvas #11065

Merged
merged 1 commit into from
Dec 24, 2023
Merged

Use WindowBuilder::with_append() to append canvas #11065

merged 1 commit into from
Dec 24, 2023

Conversation

daxpedda
Copy link
Contributor

Objective

Replace the canvas appending code with a simpler version provided by Winit v0.29.

Related: #11052.

Solution

Use WindowBuilder::with_append().

@daxpedda daxpedda mentioned this pull request Dec 22, 2023
Open
23 tasks
@Nilirad Nilirad added A-Windowing Platform-agnostic interface layer to run your app in C-Dependencies A change to the crates that Bevy depends on C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Dec 22, 2023
@mockersf mockersf added the O-Web Specific to web (WASM) builds label Dec 22, 2023
@matiqo15 matiqo15 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Dec 23, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 24, 2023
Merged via the queue into bevyengine:main with commit dc698f0 Dec 24, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@matiqo15 matiqo15 matiqo15 approved these changes

Assignees
No one assigned
Labels
A-Windowing Platform-agnostic interface layer to run your app in C-Dependencies A change to the crates that Bevy depends on C-Usability A targeted quality-of-life change that makes Bevy easier to use O-Web Specific to web (WASM) builds S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@daxpedda @mockersf @matiqo15 @alice-i-cecile @Nilirad