Remove pointless trait implementation exports in bevy_reflect
#10771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItsDoot
added
C-Code-Quality
|
Puzzled over what was going on here for a minute. I've edited your OP to say "trait implementations do not need to be re-exported", which made this immediately clear to me :) |
alice-i-cecile
changed the title
bevy_math
alice-i-cecile
approved these changes
Nov 28, 2023
|
PR title is incorrect: it removes exports from |
stepancheg
changed the title
bevy_mathbevy_reflect
ItsDoot
approved these changes
Nov 28, 2023
alice-i-cecile
added
the
S-Ready-For-Final-Review
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Dec 1, 2023
…engine#10771) Trait implementations do not need to be reexported to be used. ``` warning: unused import: `self::std::*` --> crates/bevy_reflect/src/lib.rs:502:13 | 502 | pub use self::std::*; | ^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default warning: unused import: `self::uuid::*` --> crates/bevy_reflect/src/lib.rs:503:13 | 503 | pub use self::uuid::*; | ^^^^^^^^^^^^^ warning: unused import: `impls::*` --> crates/bevy_reflect/src/lib.rs:525:9 | 525 | pub use impls::*; | ^^^^^^^^ ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trait implementations do not need to be reexported to be used.