-
-
Couldn't load subscription status.
- Fork 4.2k
Component Lifecycle Hooks and a Deferred World #10756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alice-i-cecile
merged 46 commits into
bevyengine:main
from
james-j-obrien:component-hooks
Mar 1, 2024
Merged
Changes from 40 commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
779eabe
Initial hooks implementation
james-j-obrien 6ae319e
Perf improvements, archetype flags
james-j-obrien 5c47028
Refactoring
james-j-obrien cdd1ee0
Improve command application logic
james-j-obrien 21cd650
Simplify command application to get recursive ordering
james-j-obrien 4e08655
First docs and safety comment pass
james-j-obrien b620001
Miri pass
james-j-obrien 9b76944
Add missing cfg(test)
james-j-obrien 924fb5d
Tidy iterator chains
james-j-obrien d23d1b2
Cleanup
james-j-obrien 9b490ad
CI pass
james-j-obrien b7e5462
Re-generate README.md
james-j-obrien a4d164a
Add missing safety comment
james-j-obrien 78207c3
Simplify asserts
james-j-obrien a7b5f28
Relax restrictions on register_component
james-j-obrien 7ab60b9
Update example comments
james-j-obrien ae26886
API improvements, simplify some usages of unsafe
james-j-obrien b61f62a
Rebase main.
james-j-obrien 4d1c719
Move command queue's off the function stack to prevent overflows
james-j-obrien 3bef2ce
Add method to register hooks in component trait definition
james-j-obrien 233fd30
Remove most instances of unsafe in DeferredWorld
james-j-obrien ce47702
Merge main, revert to UnsafeWorldCell, incorporate other feedback
james-j-obrien cdde4d2
Simplify code in BundleInserter
james-j-obrien 298c598
Address non-complex feedback
james-j-obrien 2e09bd4
Merge branch 'main' into component-hooks
james-j-obrien d800e7b
Merge main
james-j-obrien 642fb43
Address soundness concerns
james-j-obrien 95cfbe3
Improve docs
james-j-obrien ee8a9a4
Merge main
james-j-obrien 55b73fd
Merge main
james-j-obrien 6c948d4
Merge main
james-j-obrien 22ed176
Incorporate feedback, fix command application
james-j-obrien 9bc868b
Merge branch 'main' into component-hooks
james-j-obrien e92c745
Fix example metadata, simplify flush_commands
james-j-obrien fe4fca3
Remove missing doc link
james-j-obrien 1c2b188
Improve documentation
james-j-obrien a1a1eeb
Merge main
james-j-obrien 0022c7c
Improve handling of command queue buffers
james-j-obrien bf5a6fe
Merge branch 'main' into component-hooks
james-j-obrien 9091800
Merge main
james-j-obrien 629d694
Address soundness concern, improve safety comments
james-j-obrien c794d50
Merge main
james-j-obrien d55830a
Get hit by the new spelling callout
james-j-obrien 10978e6
Merge branch 'main' into component-hooks
james-j-obrien 5b9f2ba
Wrap unsafe operations in additional unsafe blocks, take archetype fl…
james-j-obrien 492bbb4
Get got again
james-j-obrien File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.