-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support all types of animation interpolation from gltf #10755
support all types of animation interpolation from gltf #10755
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a cursory initial scan through. I'll do a full review at a later point in time.
TIL that GLTF only supports those modes :( https://github.com/KhronosGroup/glTF-Tutorials/blob/master/gltfTutorial/gltfTutorial_007_Animations.md#interpolation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the long delay on this review! Everything looks good to me now.
@alice-i-cecile or @james7132 should this get the ready for final review label? I'm hoping this PR fixes a GLTF scene I have which uses step interpolation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this PR on my model which is broken on main due to it using step interpolation and this PR fixes that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
added the requested comment, can be merged now 👍 |
Objective
Solution
Tested with https://github.com/KhronosGroup/glTF-Sample-Models/tree/master/2.0/InterpolationTest
expected:
result:
Migration Guide
When manually specifying an animation
VariableCurve
, the interpolation type must be specified: