Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move gizmo arcs to their own file #10660

Merged
merged 1 commit into from
Nov 22, 2023
Merged

move gizmo arcs to their own file #10660

merged 1 commit into from
Nov 22, 2023

Conversation

SIGSTACKFAULT
Copy link
Contributor

Objective

  • Split different types of gizmos into their own files

Solution

  • Move arc_2d and Arc2dBuilder into arcs.rs
  • turns out there's no 3d arc function! I'll add one Soon(TM) in another MR

Changelog

  • Changed
    • moved gizmos::Arc2dBuilder to gizmos::arcs::Arc2dBuilder

Migration Guide

  • gizmos::Arc2dBuilder -> gizmos::arcs::Arc2dBuilder

@SIGSTACKFAULT
move arc_2d to it's own file
0066248 
(in another MR i'll write a 3d arc function)
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it A-Gizmos Visual editor and debug gizmos C-Code-Quality A section of code that is hard to understand or change M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide labels Nov 20, 2023
@SIGSTACKFAULT
Copy link
Contributor Author 

E: Repository 'https://packages.microsoft.com/ubuntu/22.04/prod jammy InRelease' changed its 'Origin' value from 'microsoft-ubuntu-jammy-prod jammy' to 'Pulp 3'
E: Repository 'https://packages.microsoft.com/ubuntu/22.04/prod jammy InRelease' changed its 'Label' value from 'microsoft-ubuntu-jammy-prod jammy' to ''

more externality ci issues yaaaay /s

@alice-i-cecile
Copy link
Member

Merging as trivial <3

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Nov 22, 2023
Merged via the queue into bevyengine:main with commit daf3547 Nov 22, 2023
26 checks passed
@SIGSTACKFAULT SIGSTACKFAULT deleted the gizmo-arc-file branch November 22, 2023 16:24
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@SIGSTACKFAULT
move gizmo arcs to their own file (bevyengine#10660)
4f2a488 
## Objective

- Split different types of gizmos into their own files

## Solution

- Move `arc_2d` and `Arc2dBuilder` into `arcs.rs`
- turns out there's no 3d arc function! I'll add one Soon(TM) in another
MR

## Changelog

- Changed
  - moved `gizmos::Arc2dBuilder` to `gizmos::arcs::Arc2dBuilder`

## Migration Guide

- `gizmos::Arc2dBuilder` -> `gizmos::arcs::Arc2dBuilder`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Gizmos Visual editor and debug gizmos C-Code-Quality A section of code that is hard to understand or change M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SIGSTACKFAULT @alice-i-cecile