Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable clippy::undocumented_unsafe_blocks warning across the workspace #10646

Merged
merged 9 commits into from
Nov 21, 2023
Merged

Enable clippy::undocumented_unsafe_blocks warning across the workspace #10646

merged 9 commits into from
Nov 21, 2023

Commits on Nov 19, 2023

  1. Fix safety comments so that clippy::undocumented_unsafe_blocks will d… 

    …etect them
    @13ros27
    13ros27 committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    27cceb5 View commit details
    Browse the repository at this point in the history

  2. Add #[allow(clippy::undocumented_unsafe_blocks)] where there is a S… 

    …AFETY comment higher up which applies to this unsafe block as well
    @13ros27
    13ros27 committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    357c1cf View commit details
    Browse the repository at this point in the history

  3. This is trivially safe because 1 is not 0 (should this be a // SAFETY… 

    … comment anyway?)
    @13ros27
    13ros27 committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    b01e6e1 View commit details
    Browse the repository at this point in the history

  4. I think that this is safe for the same reason that transforms above… 

    … are but I'm not 100% sure
    @13ros27
    13ros27 committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    1a7dc08 View commit details
    Browse the repository at this point in the history

  5. I assume this is why this is safe but I don't know enough about `bevy… 

    …_render` to be sure (or give more detail), also reduced the unsafe block to make it clear what function call is unsafe
    @13ros27
    13ros27 committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    f655ff9 View commit details
    Browse the repository at this point in the history

  6. Added warn(clippy::undocumented_unsafe_blocks) to the general workspa… 

    …ce lints and ignored it in mikktspace
    @13ros27
    13ros27 committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    cd63202 View commit details
    Browse the repository at this point in the history

  7. Removed unnecessary warn(clippy::undocumented_unsafe_blocks) becaus… 

    …e it is now workspace-wide
    @13ros27
    13ros27 committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    f671dae View commit details
    Browse the repository at this point in the history

  8. Replaced #[allow(clippy::undocumented_unsafe_blocks)] with actual s… 

    …afety comments
    @13ros27
    13ros27 committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    15c5c71 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2023

  1. Merge branch 'main' into undocumented-unsafe-lint

    @13ros27
    13ros27 authored Nov 21, 2023
    Configuration menu
    Copy the full SHA
    5719649 View commit details
    Browse the repository at this point in the history