Make sure added image assets are checked in camera_system #10556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Torstein Grindvik <[email protected]>
alice-i-cecile
added
C-Bug
alice-i-cecile
approved these changes
Nov 14, 2023
torsteingrindvik
changed the title
afonsolage
suggested changes
Nov 15, 2023
Co-authored-by: Afonso Lage <[email protected]>
Signed-off-by: Torstein Grindvik <[email protected]>
killercup
approved these changes
Nov 15, 2023
afonsolage
approved these changes
Nov 15, 2023
alice-i-cecile
added
the
S-Ready-For-Final-Review
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
…#10556) # Objective Make sure a camera which has had its render target changed recomputes its info. On main, the following is possible: - System A has an inactive camera with render target set to the default `Image` (i.e. white 1x1 rgba texture) Later: - System B sets the same camera active and sets the `camera.target` to a newly created `Image` **Bug**: Since `camera_system` only checks `Modified` and not `Added` events, the size of the render target is not recomputed, which means the camera will render with 1x1 size even though the new target is an entirely different size. ## Solution - Ensure `camera_system` checks `Added` image assets events ## Changelog ### Fixed - Cameras which have their render targets changed to a newly created target with a different size than the previous target will now render properly --------- Signed-off-by: Torstein Grindvik <[email protected]> Co-authored-by: Torstein Grindvik <[email protected]> Co-authored-by: Afonso Lage <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Make sure a camera which has had its render target changed recomputes its info.
On main, the following is possible:
Image(i.e. white 1x1 rgba texture)Later:
camera.targetto a newly createdImageBug: Since
camera_systemonly checksModifiedand notAddedevents, the size of the render target is not recomputed, which means the camera will render with 1x1 size even though the new target is an entirely different size.Solution
camera_systemchecksAddedimage assets eventsChangelog
Fixed