Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReadAssetBytesError::Io exposes failing path #10450

Merged
merged 3 commits into from
Nov 16, 2023
Merged

ReadAssetBytesError::Io exposes failing path #10450

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c24a01b
ReadAssetBytesError::Io exposes failing file path
orph3usLyre Nov 8, 2023
31a1148
wrap path in quotes
orph3usLyre Nov 10, 2023
ebda372
wrap path in backticks
orph3usLyre Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions crates/bevy_asset/src/loader.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ use ron::error::SpannedError;
use serde::{Deserialize, Serialize};
use std::{
any::{Any, TypeId},
path::Path,
path::{Path, PathBuf},
};
use thiserror::Error;

Expand Down Expand Up @@ -438,7 +438,13 @@ impl<'a> LoadContext<'a> {
Default::default()
};
let mut bytes = Vec::new();
reader.read_to_end(&mut bytes).await?;
reader
.read_to_end(&mut bytes)
.await
.map_err(|source| ReadAssetBytesError::Io {
path: path.path().to_path_buf(),
source,
})?;
self.loader_dependencies.insert(path.clone_owned(), hash);
Ok(bytes)
}
Expand Down Expand Up @@ -553,8 +559,12 @@ pub enum ReadAssetBytesError {
#[error(transparent)]
MissingProcessedAssetReaderError(#[from] MissingProcessedAssetReaderError),
/// Encountered an I/O error while loading an asset.
#[error("Encountered an io error while loading asset: {0}")]
Io(#[from] std::io::Error),
#[error("Encountered an io error while loading asset at "{path}": {source}")]
Io {
path: PathBuf,
#[source]
source: std::io::Error,
},
#[error("The LoadContext for this read_asset_bytes call requires hash metadata, but it was not provided. This is likely an internal implementation error.")]
MissingAssetHash,
}
Loading