Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix embedded asset path manipulation #10383

Merged
merged 9 commits into from
Feb 2, 2024
Merged

Fix embedded asset path manipulation #10383

merged 9 commits into from
Feb 2, 2024

Commits on Nov 5, 2023

  1. add example of embedded assets

    @bonsairobo
    bonsairobo committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    73ca256 View commit details
    Browse the repository at this point in the history

  2. fix: use Path API for AssetPath manipulation in embedded_path macro 

    Path manipulation is far less error prone when using the std::path::Path
API. This lets us remove all instances of "/" which is not a portable
path separator.
    @bonsairobo
    bonsairobo committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    cc90faf View commit details
    Browse the repository at this point in the history

  3. allow "wasm = true" in embedded_asset example 

    I tested it with wasm-server-runner, and it should work.
    @bonsairobo
    bonsairobo committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    7973c9f View commit details
    Browse the repository at this point in the history

  4. add example to examples/README.md

    @bonsairobo
    bonsairobo committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    21eb807 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2023

  1. fix: support running embedded_path! from a "remote" crate 

    This includes if cargo is building a crate that depends on some crates.io or git
repo crate that contains embedded assets.
    @bonsairobo
    bonsairobo committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    f8e8e0d View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2023

  1. rename embedded.rs to embedded_asset.rs to match example name

    @bonsairobo
    bonsairobo committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    56664c9 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2024

  1. test: Add tests, include failure conditions.

    @shanecelis
    shanecelis committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    04b1e98 View commit details
    Browse the repository at this point in the history

  2. excise: Remove some tests and take feedback from bonsairobo.

    @shanecelis
    shanecelis committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    fb28f69 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #1 from shanecelis/fix_embedded_path 

    test: Add tests, include failure conditions.
    @bonsairobo
    bonsairobo authored Jan 15, 2024
    Configuration menu
    Copy the full SHA
    e30d685 View commit details
    Browse the repository at this point in the history