Change From<Handle<A>> for AssetId<A> implementations to implement Borrow<Handle<A>> instead #10372
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
In my project I used to do
images.get_mut(mutable_reference_to_handle)
, but that no longer works in 0.12.0 becauseFrom<&mut Handle<A>>
isn't implemented forAssetId<A>
. This PR fixes that.Solution
Replace the implementations:
From<Handle<A>>
forAssetId<A>
From<&Handle<A>>
forAssetId<A>
With:
impl<T: Borrow<Handle<A>>, A: Asset> From<T> for AssetId<A>
Result: You can now pass mutable references to handles to functions that require
AssetId
sChangelog
Handle
s asAssetId
s