Added 'clear_children' and 'replace_children' methods to BuildWorldChildren to be consistent with BuildChildren. #10311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BuildWorldChildren to be consistent with BuildChildren.
alice-i-cecile
added
A-ECS
alice-i-cecile
approved these changes
Oct 29, 2023
Trashtalk217
approved these changes
Oct 31, 2023
alice-i-cecile
added
the
S-Ready-For-Final-Review
ameknite
pushed a commit
to ameknite/bevy
that referenced
this pull request
Nov 6, 2023
…ildren to be consistent with BuildChildren. (bevyengine#10311) # Objective The `BuildWorldChildren` API was missing several methods that exist in `BuildChildren`. ## Solution Added the methods (and tests) for consistency.
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
…ildren to be consistent with BuildChildren. (bevyengine#10311) # Objective The `BuildWorldChildren` API was missing several methods that exist in `BuildChildren`. ## Solution Added the methods (and tests) for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
The
BuildWorldChildrenAPI was missing several methods that exist inBuildChildren.Solution
Added the methods (and tests) for consistency.