Skip to content

Conversation

@mockersf
Copy link
Member

@mockersf mockersf commented Dec 7, 2020

fix new format and new clippy

also use a fixed nightly version to avoid surprise breaks

  • pros: no more surprise CI failure
  • cons: need to update the nightly version regularly (monthly?)

I think it's better to use a fixed version to avoid having a bunch of PRs break regularly

- uses: actions-rs/toolchain@v1
with:
toolchain: nightly
toolchain: nightly-2020-12-07
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good call! the constant breakage is definitely annoying

@cart cart merged commit a3bca7e into bevyengine:master Dec 7, 2020
@fopsdev fopsdev mentioned this pull request Jan 24, 2021
@mockersf mockersf deleted the fix-ci branch April 27, 2021 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants