Allow optional extraction of resources from the main world #10109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regnarock
force-pushed
the
fix/optional_resource
branch
2 times, most recently
from
c30cb17
to
83dcc86
Compare
alice-i-cecile
added
A-Rendering
alice-i-cecile
approved these changes
Oct 13, 2023
regnarock
force-pushed
the
fix/optional_resource
branch
from
83dcc86
to
3ef2eb3
Compare
mockersf
approved these changes
Oct 13, 2023
alice-i-cecile
added
the
S-Ready-For-Final-Review
james7132
approved these changes
Oct 14, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
ameknite
pushed a commit
to ameknite/bevy
that referenced
this pull request
Nov 6, 2023
…e#10109) # Objective From my understanding, although resources are not meant to be created and removed at every frame, they are still meant to be created dynamically during the lifetime of the App. But because the extract_resource API does not allow optional resources from the main world, it's impossible to use resources in the render phase that were not created before the render sub-app itself. ## Solution Because the ECS engine already allows for system parameters to be `Option<Res>`, it just had to be added. --- ## Changelog - Changed - `extract_resource` now takes an optional main world resource - Fixed - `ExtractResourcePlugin` doesn't cause panics anymore if the resource is not already inserted
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
…e#10109) # Objective From my understanding, although resources are not meant to be created and removed at every frame, they are still meant to be created dynamically during the lifetime of the App. But because the extract_resource API does not allow optional resources from the main world, it's impossible to use resources in the render phase that were not created before the render sub-app itself. ## Solution Because the ECS engine already allows for system parameters to be `Option<Res>`, it just had to be added. --- ## Changelog - Changed - `extract_resource` now takes an optional main world resource - Fixed - `ExtractResourcePlugin` doesn't cause panics anymore if the resource is not already inserted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
From my understanding, although resources are not meant to be created and removed at every frame, they are still meant to be created dynamically during the lifetime of the App.
But because the extract_resource API does not allow optional resources from the main world, it's impossible to use resources in the render phase that were not created before the render sub-app itself.
Solution
Because the ECS engine already allows for system parameters to be
Option<Res>, it just had to be added.Changelog
Changed
extract_resourcenow takes an optional main world resourceFixed
ExtractResourcePlugindoesn't cause panics anymore if the resource is not already inserted