Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement minimal reflection probes. #10057

Merged
merged 52 commits into from
Jan 8, 2024
Merged

Implement minimal reflection probes. #10057

merged 52 commits into from
Jan 8, 2024

Commits on Oct 9, 2023

  1. WIP reflection probes. 

    Current problems:

* There's no logic yet to determine which reflection probe to apply to
  each mesh; it always takes the first one.

* Reflection probes are regenerated on every frame.
    @pcwalton
    pcwalton committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    ec71332 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. Remove mipmap generation

    @pcwalton
    pcwalton committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    3fcb91f View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. Implement view reflection probes and reflection probe selection

    @pcwalton
    pcwalton committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    1abe709 View commit details
    Browse the repository at this point in the history

  2. Add an example. Still need the actual maps

    @pcwalton
    pcwalton committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    9f2a33e View commit details
    Browse the repository at this point in the history

  3. Revert changes to pbr example

    @pcwalton
    pcwalton committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    5d9b49c View commit details
    Browse the repository at this point in the history

  4. Remove obsolete comment

    @pcwalton
    pcwalton committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    3179368 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2023

  1. Improve error messages a bit

    @pcwalton
    pcwalton committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    8c8478b View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into reflection-probes

    @pcwalton
    pcwalton committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    d61d305 View commit details
    Browse the repository at this point in the history

  3. Get reflection probes demo mostly working

    @pcwalton
    pcwalton committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    70643e1 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2023

  1. Compress the textures

    @pcwalton
    pcwalton committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    77c6510 View commit details
    Browse the repository at this point in the history

  2. Document everything and clean up

    @pcwalton
    pcwalton committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    9948839 View commit details
    Browse the repository at this point in the history

  3. Better documentation for light probes

    @pcwalton
    pcwalton committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    cb739cf View commit details
    Browse the repository at this point in the history

  4. Update examples README

    @pcwalton
    pcwalton committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    8cf4e7c View commit details
    Browse the repository at this point in the history

  5. Update to be deferred compatible

    @pcwalton
    pcwalton committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    f9c79eb View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. Various fixes

    @pcwalton
    pcwalton committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    8240e1f View commit details
    Browse the repository at this point in the history

  2. Improve documentation

    @pcwalton
    pcwalton committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    6c8b9a2 View commit details
    Browse the repository at this point in the history

  3. Remove unused texture

    @pcwalton
    pcwalton committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    d6fc1f8 View commit details
    Browse the repository at this point in the history

  4. Fix compile error

    @pcwalton
    pcwalton committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    05cc37e View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2023

  1. Merge remote-tracking branch 'origin/main' into reflection-probes

    @pcwalton
    pcwalton committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    f55a372 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2023

  1. Merge remote-tracking branch 'origin/main' into reflection-probes

    @pcwalton
    pcwalton committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    2b7df6c View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2023

  1. WIP, not uploaded

    @pcwalton
    pcwalton committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    fcbfc04 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2023

  1. Merge remote-tracking branch 'origin/main' into reflection-probes

    @pcwalton
    pcwalton committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    6220079 View commit details
    Browse the repository at this point in the history

  2. WIP, not pushed yet

    @pcwalton
    pcwalton committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    46fff90 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. Get things mostly working again

    @pcwalton
    pcwalton committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    47b40a5 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. Get things working, including without binding arrays

    @pcwalton
    pcwalton committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    fccaf3c View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2023

  1. Address some review comments

    @pcwalton
    pcwalton committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    6cc256f View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into reflection-probes

    @pcwalton
    pcwalton committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    1f6f47d View commit details
    Browse the repository at this point in the history

  3. Add some more documentation

    @pcwalton
    pcwalton committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    2d6b3ab View commit details
    Browse the repository at this point in the history

  4. Address a couple more review comments

    @pcwalton
    pcwalton committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    df2bfb8 View commit details
    Browse the repository at this point in the history

  5. Remove the half-extents from light probes

    @pcwalton
    pcwalton committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    b074f44 View commit details
    Browse the repository at this point in the history

  6. Address more review comments

    @pcwalton
    pcwalton committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    dd63661 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2023

  1. Use a tighter bounding box in the example

    @pcwalton
    pcwalton committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    645b64b View commit details
    Browse the repository at this point in the history

  2. Clippy police

    @pcwalton
    pcwalton committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    bc45758 View commit details
    Browse the repository at this point in the history

  3. Address review comment

    @pcwalton
    pcwalton committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    5dc6874 View commit details
    Browse the repository at this point in the history

  4. Merge environment_map and light_probe into one

    @pcwalton
    pcwalton committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    35b8ad2 View commit details
    Browse the repository at this point in the history

  5. rustfmt police

    @pcwalton
    pcwalton committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    1ebc40b View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/main' into reflection-probes

    @pcwalton
    pcwalton committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    ffe11df View commit details
    Browse the repository at this point in the history

  7. Clippy police

    @pcwalton
    pcwalton committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    b30602f View commit details
    Browse the repository at this point in the history

  8. Clippy police

    @pcwalton
    pcwalton committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    75794ae View commit details
    Browse the repository at this point in the history

  9. TOML and check-doc police

    @pcwalton
    pcwalton committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    12ff889 View commit details
    Browse the repository at this point in the history

  10. Doc check police

    @pcwalton
    pcwalton committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    12463b4 View commit details
    Browse the repository at this point in the history

  11. Merge remote-tracking branch 'origin/main' into reflection-probes

    @pcwalton
    pcwalton committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    4e138cd View commit details
    Browse the repository at this point in the history

  12. Try to unbreak D3D12

    @pcwalton
    pcwalton committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    63cb7cb View commit details
    Browse the repository at this point in the history

  13. Remove the skybox texture to save space in the Bevy repo

    @pcwalton
    pcwalton committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    a7a0980 View commit details
    Browse the repository at this point in the history

  14. Fix assets mistake

    @pcwalton
    pcwalton committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    0560924 View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2023

  1. Merge remote-tracking branch 'origin/main' into reflection-probes

    @pcwalton
    pcwalton committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    d7c1b14 View commit details
    Browse the repository at this point in the history

  2. Address review comments

    @pcwalton
    pcwalton committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    38c0f00 View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2024

  1. Merge remote-tracking branch 'origin/main' into reflection-probes

    @pcwalton
    pcwalton committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    cdec3c5 View commit details
    Browse the repository at this point in the history

  2. Disable diffuse environment maps when lightmaps are present

    @pcwalton
    pcwalton committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    0da1086 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2024

  1. Clippy police

    @pcwalton
    pcwalton committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    52aba03 View commit details
    Browse the repository at this point in the history

  2. Doc-check police

    @pcwalton
    pcwalton committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    729824e View commit details
    Browse the repository at this point in the history

  3. Split out the radiance and irradiance computation into a separate 

    function
    @pcwalton
    pcwalton committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    bd2bcc4 View commit details
    Browse the repository at this point in the history