Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScheduleBuildSettings should have a use_shortnames field #7441

Closed
alice-i-cecile opened this issue Jan 31, 2023 · 0 comments
Closed

ScheduleBuildSettings should have a use_shortnames field #7441

alice-i-cecile opened this issue Jan 31, 2023 · 0 comments
Labels
A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use

Comments

@alice-i-cecile
Copy link
Member

What problem does this solve or what need does it fill?

System names can be very long and challenging to read when resolving

What solution would you like?

Add the field, set to false by default.
Use the existing short_name code in bevy_utils to parse the system and component names if that field is set to true.

Additional context

Please don't do this until #7267 is merged for the sake of my sanity.
@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events S-Blocked This cannot move forward until something else changes C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Jan 31, 2023
@james7132 james7132 removed the S-Blocked This cannot move forward until something else changes label Feb 17, 2023
@james7132 james7132 mentioned this issue Feb 17, 2023
Closed
@bors bors bot closed this as completed in 0425673 Feb 17, 2023
myreprise1 pushed a commit to myreprise1/bevy that referenced this issue Feb 18, 2023
@james7132 @myreprise1
Cleanup ScheduleBuildSettings (bevyengine#7721)
b026299 
# Objective
Fix bevyengine#7440. Fix bevyengine#7441. 

## Solution

 * Remove builder functions on `ScheduleBuildSettings` in favor of public fields, move docs to the fields.
 * Add `use_shortnames` and use it in `get_node_name` to feed it through `bevy_utils::get_short_name`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Merged by Bors] - Cleanup ScheduleBuildSettings james7132/bevy
2 participants
@james7132 @alice-i-cecile