Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indicate AudioSource's bytes field must follow a supported audio file format #6299

Closed
harudagondi opened this issue Oct 19, 2022 · 0 comments
Closed

Indicate AudioSource's bytes field must follow a supported audio file format #6299

harudagondi opened this issue Oct 19, 2022 · 0 comments
Labels
A-Audio Sounds playback and modification C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy

Comments

@harudagondi
Copy link
Member

How can Bevy's documentation be improved?

Unlike bevy_kira_audio and bevy_oddio, where you have to manually convert an audio file to a vector of frames (a frame is usually [f32; 2]), the bytes field of AudioSource must follow a supported file format (internally, wav, vorbis, flac, mp3 or any audio file supported by symphonia).

This is currently not yet indicated in the documentation.
@harudagondi harudagondi added C-Docs An addition or correction to our documentation S-Needs-Triage This issue needs to be labelled labels Oct 19, 2022
@harudagondi harudagondi changed the title Indicate AudioSource's bytes field follows an audio file format Indicate AudioSource's bytes field must follow a supported audio file format Oct 19, 2022
@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy A-Audio Sounds playback and modification and removed S-Needs-Triage This issue needs to be labelled labels Oct 19, 2022
@harudagondi harudagondi mentioned this issue Oct 19, 2022
Closed
@dis-da-moe dis-da-moe mentioned this issue Nov 14, 2022
Closed
@bors bors bot closed this as completed in 81153a8 Dec 11, 2022
alradish pushed a commit to alradish/bevy that referenced this issue Jan 22, 2023
@dis-da-moe @alradish
document file formats for bytes field of AudioSource (bevyengine#…
fe73dd0 
…6619)

# Objective

Fixes bevyengine#6299 

## Solution

Change one line of documentation.

Co-authored-by: dis-da-moe <[email protected]>
ItsDoot pushed a commit to ItsDoot/bevy that referenced this issue Feb 1, 2023
@dis-da-moe @ItsDoot
document file formats for bytes field of AudioSource (bevyengine#…
c65c08b 
…6619)

# Objective

Fixes bevyengine#6299 

## Solution

Change one line of documentation.

Co-authored-by: dis-da-moe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Audio Sounds playback and modification C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy
Projects
Audio
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Merged by Bors] - document file formats for bytes field of AudioSource dis-da-moe/bevy
2 participants
@alice-i-cecile @harudagondi