Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert change to scene saving example to demonstrate async API #5951

Closed
alice-i-cecile opened this issue Sep 11, 2022 · 0 comments
Closed

Revert change to scene saving example to demonstrate async API #5951

alice-i-cecile opened this issue Sep 11, 2022 · 0 comments
Labels
A-Scenes Serialized ECS data stored on the disk C-Code-Quality A section of code that is hard to understand or change C-Examples An addition or correction to our examples

Comments

@alice-i-cecile
Copy link
Member

This is a bad idea, and we should really not show usage of a blocking api (file writing) in a system.

Originally posted by @mockersf in #5949 (comment)
@alice-i-cecile alice-i-cecile added C-Examples An addition or correction to our examples C-Code-Quality A section of code that is hard to understand or change A-Scenes Serialized ECS data stored on the disk labels Sep 11, 2022
@mockersf mockersf mentioned this issue Sep 11, 2022
Closed
@bors bors bot closed this as completed in 1b97205 Sep 12, 2022
nicopap pushed a commit to nicopap/bevy that referenced this issue Sep 12, 2022
@mockersf @nicopap
Scene example: write file in a task (bevyengine#5952)
c1bbab5 
# Objective

- Fix bevyengine#5951 
- Improve on bevyengine#5949 by not risking blocking a system

## Solution

- Wrap file writing in a task
james7132 pushed a commit to james7132/bevy that referenced this issue Oct 28, 2022
@mockersf @james7132
Scene example: write file in a task (bevyengine#5952)
cab6ae8 
# Objective

- Fix bevyengine#5951 
- Improve on bevyengine#5949 by not risking blocking a system

## Solution

- Wrap file writing in a task
ItsDoot pushed a commit to ItsDoot/bevy that referenced this issue Feb 1, 2023
@mockersf @ItsDoot
Scene example: write file in a task (bevyengine#5952)
29b1be0 
# Objective

- Fix bevyengine#5951 
- Improve on bevyengine#5949 by not risking blocking a system

## Solution

- Wrap file writing in a task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Scenes Serialized ECS data stored on the disk C-Code-Quality A section of code that is hard to understand or change C-Examples An addition or correction to our examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Merged by Bors] - Scene example: write file in a task mockersf/bevy
1 participant
@alice-i-cecile