Why not let GltfMaterialName display as Name?

[rendaoer]

What problem does this solve or what need does it fill?

Although GltfMaterialName is added when the material is generated, when checking it in Inspect, it still shows the default Mesh + index (Mesh.0, Mesh.1, Mesh.2), and you need to check it in GltfMaterialName

What solution would you like?

If GltfMaterialName exists, use it as Name

What alternative(s) have you considered?

None

Additional context

[rendaoer]

Old practice

if let Some(name) = material.name() {
    mesh_entity.insert(GltfMaterialName(String::from(name)));
}

mesh_entity.insert(Name::new(primitive_name(&mesh, &primitive)));

[rendaoer]

My Modification

if let Some(name) = material.name() {
    mesh_entity.insert((
        Name::new(name.to_string()),
        GltfMaterialName(name.to_string()),
    ));
} else {
    mesh_entity.insert(Name::new(primitive_name(&mesh, &primitive)));
}

If GltfMaterialName exists, the material name is added as Name, and Mesh + index is not used as Name.

[rendaoer]

Test code, modified from examples/load_gltf.rs

//! Loads and renders a glTF file as a scene.

use bevy::{gltf::GltfMaterialName, prelude::*, scene::SceneInstanceReady};

fn main() {
    App::new()
        .add_plugins(DefaultPlugins)
        .add_systems(Startup, setup)
        .add_observer(on_scene_load)
        .run();
}

fn setup(mut commands: Commands, asset_server: Res<AssetServer>) {
    commands.spawn((
        Camera3d::default(),
        Transform::from_xyz(0.7, 0.7, 1.0).looking_at(Vec3::new(0.0, 0.3, 0.0), Vec3::Y),
    ));

    commands.spawn((DirectionalLight {
        shadows_enabled: true,
        ..default()
    },));

    commands.spawn(SceneRoot(asset_server.load(
        GltfAssetLabel::Scene(0).from_asset("models/FlightHelmet/FlightHelmet.gltf"),
    )));
}

fn on_scene_load(
    trigger: Trigger<SceneInstanceReady>,
    children: Query<&Children>,
    names: Query<&Name>,
    material_names: Query<&GltfMaterialName>,
) {
    let target = trigger.target();

    for child in children.iter_descendants(target) {
        let name = if let Ok(name) = names.get(child) {
            Some(name.to_string())
        } else {
            None
        };
        let material_name = if let Ok(name) = material_names.get(child) {
            Some(name.0.clone())
        } else {
            None
        };

        info!("Entity name:{:?} | material name:{:?}", name, material_name);
    }
}

[rendaoer]

I accidentally closed Issues using an unknown Github shortcut

[rendaoer]

Run log: