Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some examples need tweaks after new exposure settings #11376

Closed
3 tasks
rparrett opened this issue Jan 16, 2024 · 4 comments · Fixed by #11389
Closed
3 tasks

Some examples need tweaks after new exposure settings #11376

rparrett opened this issue Jan 16, 2024 · 4 comments · Fixed by #11389
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples

Comments

@rparrett
Copy link
Contributor

Bevy version

main, since #11347

What you did

Caught by https://thebevyflock.github.io/bevy-example-runner/

What went wrong

The following all seem much darker than intended:

  • render_ui_to_texture
  • asset_loading
  • hot_asset_reloading
@rparrett rparrett added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Jan 16, 2024
@rparrett rparrett changed the title Some issues need tweaks after new exposure settings Some examples need tweaks after new exposure settings Jan 16, 2024
@rparrett rparrett added A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples and removed S-Needs-Triage This issue needs to be labelled labels Jan 16, 2024
@JMS55
Copy link
Contributor

JMS55 commented Jan 17, 2024

@GitGhillie any interest in doing these 3 as well?

@GitGhillie
Copy link
Contributor

Sure! I'll get to them after work today

@GitGhillie
Copy link
Contributor

Thx for checking @rparrett! That example runner tool is great.

@rparrett
Copy link
Contributor Author

Credit goes to @mockersf , I just try to take some of the burden of creating github issues.

github-merge-queue bot pushed a commit that referenced this issue Jan 17, 2024
…11389)

# Objective

Fixes #11376
During the development of the exposure settings PR (#11347) all examples
with lighting had to be adjusted, but three were missed or simply didn't
exist yet at the time. This PR restores the brightness in those examples
again:

render_ui_to_texture
asset_loading
hot_asset_reloading

All of them are a bit brighter now compared to before the exposure PR,
but it looks better IMO.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants