Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ArchetypeEntity::entity into ArchetypeEntity::id #11050

Closed
Shatur opened this issue Dec 21, 2023 · 1 comment · Fixed by #11118
Closed

Rename ArchetypeEntity::entity into ArchetypeEntity::id #11050

Shatur opened this issue Dec 21, 2023 · 1 comment · Fixed by #11118
Labels
A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide

Comments

@Shatur
Copy link
Contributor

Shatur commented Dec 21, 2023

What problem does this solve or what need does it fill?

We have EntityWorldMut, EntityMut and EntityRef with method called id that returns Entity.
But it's inconsistent with ArchetypeEntity::entity.

What solution would you like?

I would suggest to rename ArchetypeEntity::entity into ArchetypeEntity::id.
@Shatur Shatur added C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled labels Dec 21, 2023
@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide and removed C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled labels Dec 21, 2023
@tharnival
Copy link
Contributor

I'll do it.

@tharnival tharnival mentioned this issue Dec 28, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 1, 2024
Rename ArchetypeEntity::entity into ArchetypeEntity::id (#11118)
ffded5b 
# Objective

Fixes #11050

Rename ArchetypeEntity::entity to ArchetypeEntity::id to be consistent
with `EntityWorldMut`, `EntityMut` and `EntityRef`.

## Migration Guide

The method `ArchetypeEntity::entity` has been renamed to
`ArchetypeEntity::id`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename ArchetypeEntity::entity into ArchetypeEntity::id tharnival/bevy
3 participants
@alice-i-cecile @tharnival @Shatur