-
-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Big puppeteer-extra upgrade. #649
base: master
Are you sure you want to change the base?
Conversation
@UrielCh I've published It contains new/refactored code, clean deps, new test runners and a few other features like this one: import { chromium } from 'playwright-extra'
import StealthPlugin from 'puppeteer-extra-plugin-stealth'
chromium.use(StealthPlugin())
// New way to overwrite the default options of stealth evasion plugins
// https://github.com/berstend/puppeteer-extra/tree/master/packages/puppeteer-extra-plugin-stealth/evasions
chromium.plugins.setDependencyDefaults('stealth/evasions/webgl.vendor', {
vendor: 'Bob',
renderer: 'Alice'
}) Once the dust has settled doing housekeeping in the repo (especially updating dependencies/linting, etc) is in order 😄 I used your PR as a reference while implementing the new code 👍 |
Hi, |
Any updates on this pull request? Windows compatibility is still not available, and proper typescript rewrites to the plugins and rest would improve overall dev experience. This PR would resolve both of my main pain points. |
One of my Biggest PR.
This PR contains the following changes:
Improvements
in this case typing enforce all Plugin constuctors.
interface PluginData
puppeteer-extra/index.ts
and extract aPuppeteerExtra.ts
PuppeteerPage
,PuppeteerTarget
,PuppeteerBrowser
,PuppeteerConnectOptions
,PuppeteerRequest
,PuppeteerClickOptions
,PuppeteerNavigationOptions
,PuppeteerResponse
type exports inpuppeteer-extra-plugin
to symplify typing in plugins.package.json
Breaking changes:Display warning if older plugins are loaded._getMissingDependencies(plugins: any)
removed in favor ofget dependencies()
dependencies simply return a list of plugin names,
_getMissingDependencies
was a mess.supportget dependencies()
retrun an Array instead of a SetSet
orArray
Regression
the linter is mostly disabled, I have some issues with yarn + lerna workspaces.I live explicit typescript version14
in dependency instead of*
.drop long time deprecatedpuppeteer-firefox
TODO
fix pptr 14 supportChanges I self-restrain