Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#276 - Main merged to v2.4.0 #4284

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Conversation

sh16011993
Copy link
Collaborator

@sh16011993 sh16011993 commented Jan 23, 2025

Main merged to v2.4.0

lewischen-aot and others added 2 commits January 23, 2025 16:59
…tory (#4278)

- Made the additional transportation exception document uploader field
mandatory field for all options for the following areas:
  - Application
  - Change Request
- Made the BC residency exception document uploader field mandatory
field for all options for the following areas:
  - Application

Screenshot for the BC residency file uploader

![image](https://github.com/user-attachments/assets/c3342473-d2c0-47cd-b455-77e6964d1fb4)

Screenshot for the additional transportation file uploader

![image](https://github.com/user-attachments/assets/6235d85e-c002-44aa-8dbb-1ff3a67df890)
### As a part of this PR, the following have been completed:

1) Added a hamburger menu to allow for the top bar navigation when the
screen size is reduced.
2) The modal dialogs throughout the application have been updated to use
the `useDisplay` composable.

**Video representing the demo for the navigation drawer and the menu:**


https://github.com/user-attachments/assets/1c6d4f86-e4f3-402a-bcb6-067e275300e3

**Video representing the demo for the modal dialogs:**


https://github.com/user-attachments/assets/aa777d6c-6756-497f-a7cb-d55eef380838
@sh16011993 sh16011993 self-assigned this Jan 23, 2025
@sh16011993 sh16011993 added the Branch Sync-up Branch features move between main/release/hotfix branches. label Jan 23, 2025
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.52% ( 3864 / 17159 )
Methods: 10.32% ( 224 / 2170 )
Lines: 25.93% ( 3336 / 12866 )
Branches: 14.32% ( 304 / 2123 )

Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.59% ( 589 / 898 )
Methods: 59.63% ( 65 / 109 )
Lines: 68.72% ( 468 / 681 )
Branches: 51.85% ( 56 / 108 )

Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 86.14% ( 1249 / 1450 )
Methods: 82.42% ( 136 / 165 )
Lines: 88.51% ( 1032 / 1166 )
Branches: 68.07% ( 81 / 119 )

Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 68.11% ( 6019 / 8837 )
Methods: 65.84% ( 742 / 1127 )
Lines: 71.94% ( 4712 / 6550 )
Branches: 48.71% ( 565 / 1160 )

Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@dheepak-aot dheepak-aot changed the title Main merged to v2.4.0 #276 - Main merged to v2.4.0 Jan 23, 2025
@sh16011993 sh16011993 merged commit 86f6498 into release/v2.4.0 Jan 23, 2025
23 checks passed
@sh16011993 sh16011993 deleted the main_merged_to_v2.4.0 branch January 23, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Branch Sync-up Branch features move between main/release/hotfix branches.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants