#3900 - Small screen responsiveness: Top Menu Nav Hamburger #4272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guru-aot
reviewed
Jan 21, 2025
| @@ -9,7 +9,7 @@ | |||
| class="navigation-btn float-left" | |||
| > | |||
| <v-btn | |||
| v-if="hasAuthenticatedStudentAccount" | |||
| v-show="hasAuthenticatedStudentAccount && showExpandedMenu" | |||
There was a problem hiding this comment.
can we have a computed value "hasAuthenticatedStudentAccount && showExpandedMenu"?
There was a problem hiding this comment.
Can you please suggest a suitable constant name.
There was a problem hiding this comment.
isStudentMenuVisible something like this
There was a problem hiding this comment.
Please check the display helpers as well if we can achieve the same by CSS class. https://vuetifyjs.com/en/styles/display/
dheepak-aot
reviewed
Jan 21, 2025
dheepak-aot
reviewed
Jan 21, 2025
dheepak-aot
reviewed
Jan 21, 2025
dheepak-aot
reviewed
Jan 21, 2025
- Changed the menu dropdown to have the navigation drawer for small screen devices - Changed the dialog modals to use the useDisplay composable provided by Vuetify
dheepak-aot
reviewed
Jan 22, 2025
dheepak-aot
reviewed
Jan 23, 2025
dheepak-aot
reviewed
Jan 23, 2025
|
Backend Unit Tests Coverage Report
|
dheepak-aot
approved these changes
Jan 23, 2025
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
guru-aot
approved these changes
Jan 23, 2025
sh16011993
deleted the
3900_small_screen_responsiveness_top_menu_nav_hamburger
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of this PR, the following have been completed:
useDisplaycomposable.Video representing the demo for the navigation drawer and the menu:
2025-01-22.14-35-24.mp4
Video representing the demo for the modal dialogs:
2025-01-22.14-41-28.mp4