#4023 - Additional transportation and bc residency uploaders is mandatory #4278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewischen-aot
added
Enhancement
| @@ -480,7 +479,7 @@ | |||
| "scrollToTop": false, | |||
| "collapsible": false, | |||
| "key": "additionTransportationPanel", | |||
| "customConditional": "", | |||
| "customConditional": "show = (data.transportationCostSituation === 'noLimit' || data.transportationCostSituation === 'special' || data.transportationCostSituation === 'educationPlacement');", | |||
There was a problem hiding this comment.
The uploader must be present and required independently of the select option, is it right?
Do we need this condition?
There was a problem hiding this comment.
This is added to be consistent with the behavior in the additional transportation section in the student application. I can remove it if this is not needed.
There was a problem hiding this comment.
Custom condition is removed.
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
andrewsignori-aot
approved these changes
Jan 23, 2025
guru-aot
approved these changes
Jan 23, 2025
lewischen-aot
deleted the
feature/#4023-additional-transportation-bc-residency-uploader
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshot for the BC residency file uploader
Screenshot for the additional transportation file uploader
