Merge Release branch v2.3.0 to main #4257
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**As a part of this PR, release v2.2.0 is merged to v2.3.0** --------- Co-authored-by: Bidyashish <[email protected]> Co-authored-by: Andrew Boni Signori <[email protected]>
### As a part of this PR, the following was fixed: **Issue:** When a student creates a profile in SIMS and they have PPD = true in a matching `sfas_individuals` record, their `students.disability_status` status is `Not requested`. **Fix:** The query retrieving the `sfas_individual` for a matching SIMS record was not returning the individual's `ppdStatus` and the `ppdStatusDate`. Added it to fix the issue. **Fix Screenshot:** <img width="1729" alt="image" src="https://github.com/user-attachments/assets/80e5165f-0097-4777-ace1-363819e4cff9" /> --------------------------------------------------------------------------------------------------------- <img width="1727" alt="image" src="https://github.com/user-attachments/assets/5c996748-53ba-4ae3-ab7c-2e58b63541b4" />
**Acceptance Criteria** - [x] Update the Eligible to Receive amount to not include **BC Total Grant** from the `disbursement_values` so it's not being double counted. - [x] Check post ecert calculation. This is when the BC Total grant is added to the table. **Technical** - [x] If E2E tests are in place please adjust it to cover this scenario, including the "BC Total Grant" in the data setup and asserting the expected value. E2E test data is taken from sample data.
…4242) **Acceptance Criteria** - [x] Update the Eligible to Receive amount to not include **BC Total Grant** from the `disbursement_values` so it's not being double counted. - [x] Check post ecert calculation. This is when the BC Total grant is added to the table. **Technical** - [x] If E2E tests are in place please adjust it to cover this scenario, including the "BC Total Grant" in the data setup and asserting the expected value. E2E test data is taken from sample data.
|
bidyashish
changed the title
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
andrewsignori-aot
temporarily deployed
to
PROD
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#274 - Merge release v2.2.0 to v2.3.0
#4223 - Student Bridge Match - PPD Status Not Importing
#4226 - NOA Eligible to Receive - Double Counting BC Grants