Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Student Bridge Match - PPD Status Not Importing #4223

Closed
CarlyCotton opened this issue Jan 9, 2025 · 1 comment
Closed

Student Bridge Match - PPD Status Not Importing #4223

CarlyCotton opened this issue Jan 9, 2025 · 1 comment
Assignees
@sh16011993 @CarlyCotton
Labels
Bug Something isn't working Business Items under Business Consideration
Milestone
Priority Enhancem...

Comments

@CarlyCotton
Copy link
Collaborator

CarlyCotton commented Jan 9, 2025 •
edited by ninosamson
Loading

Expected Behaviour
When a student creates a profile in SIMS, their PD or PPD status is attached to their SIMS profile.

Current Behaviour
When a student creates a profile in SIMS and they have PPD = true in a matching sfas_individuals record, their students.disability_status status is Not requested.

Additional Context
When reviewing production records, there are 81 sfas_individuals who have matched with SIMS profiles that have PPD Status = True. None of these statuses have transfered to the student's profile on creation.

Note: No need to make any PROD database fixes for PPD status that wasn't pulled over.
@CarlyCotton CarlyCotton added Business Items under Business Consideration Bug Something isn't working labels Jan 9, 2025
@CarlyCotton CarlyCotton self-assigned this Jan 9, 2025
@CarlyCotton CarlyCotton added High Priority Priority ticket for grooming and removed High Priority Priority ticket for grooming labels Jan 9, 2025
@CarlyCotton CarlyCotton changed the title Student Bridge Match - PD Status Not Importing Student Bridge Match - PPD Status Not Importing Jan 10, 2025
@Joshua-Lakusta
Copy link
Collaborator

Joshua-Lakusta commented Jan 10, 2025 •
edited
Loading

Aiming for hotfix in 2.3 release. Devs to discuss after stand up and aim to include in 2.3 release.

sh16011993 added a commit that referenced this issue Jan 14, 2025
@sh16011993
#4223 - Student Bridge Match - PPD Status Not Importing
75c0b89
sh16011993 added a commit that referenced this issue Jan 14, 2025
@sh16011993
#4223 - Student Bridge Match - PPD Status Not Importing (#4230)
ffb5aa5 
### As a part of this PR, the following was fixed:

**Issue:** When a student creates a profile in SIMS and they have PPD =
true in a matching `sfas_individuals` record, their
`students.disability_status` status is `Not requested`.

**Fix:** The query retrieving the `sfas_individual` for a matching SIMS
record was not returning the individual's `ppdStatus` and the
`ppdStatusDate`. Added it to fix the issue.

**Fix Screenshot:**

<img width="1729" alt="image"
src="https://github.com/user-attachments/assets/80e5165f-0097-4777-ace1-363819e4cff9"
/>


---------------------------------------------------------------------------------------------------------

<img width="1727" alt="image"
src="https://github.com/user-attachments/assets/5c996748-53ba-4ae3-ab7c-2e58b63541b4"
/>
This was referenced Jan 16, 2025
Closed
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 17, 2025
@bidyashish @sh16011993
@andrewsignori-aot @dheepak-aot
#274 - Merge Release branch v2.3.0 to main (#4260)
da9f0dc 
Release 2.3 from intermediate branch.

#4223 [- Student Bridge Match - PPD
Status Not Importing
](ffb5aa5)

---------

Co-authored-by: Shashank Shekhar <[email protected]>
Co-authored-by: Andrew Boni Signori <[email protected]>
Co-authored-by: Dheepak Ramanathan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sh16011993 sh16011993

@CarlyCotton CarlyCotton

Labels
Bug Something isn't working Business Items under Business Consideration
Projects
None yet
Milestone
Priority Enhancements post full time MVP
Development

No branches or pull requests
5 participants
@sh16011993 @ninosamson @Joshua-Lakusta @CarlyCotton @AnnaPBashkatova