Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4223 - Student Bridge Match - PPD Status Not Importing #4230

Merged

Conversation

sh16011993
Copy link
Collaborator

@sh16011993 sh16011993 commented Jan 14, 2025

As a part of this PR, the following was fixed:

Issue: When a student creates a profile in SIMS and they have PPD = true in a matching sfas_individuals record, their students.disability_status status is Not requested.

Fix: The query retrieving the sfas_individual for a matching SIMS record was not returning the individual's ppdStatus and the ppdStatusDate. Added it to fix the issue.

Fix Screenshot:

image
image

@sh16011993 sh16011993 added the SIMS-Api SIMS-Api label Jan 14, 2025
@sh16011993 sh16011993 self-assigned this Jan 14, 2025
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.22% ( 3784 / 17027 )
Methods: 10.18% ( 219 / 2152 )
Lines: 25.67% ( 3279 / 12775 )
Branches: 13.62% ( 286 / 2100 )

Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.59% ( 589 / 898 )
Methods: 59.63% ( 65 / 109 )
Lines: 68.72% ( 468 / 681 )
Branches: 51.85% ( 56 / 108 )

Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 86.14% ( 1249 / 1450 )
Methods: 82.42% ( 136 / 165 )
Lines: 88.51% ( 1032 / 1166 )
Branches: 68.07% ( 81 / 119 )

Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 67.4% ( 5922 / 8787 )
Methods: 65.09% ( 729 / 1120 )
Lines: 71.33% ( 4647 / 6515 )
Branches: 47.4% ( 546 / 1152 )

Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@andrepestana-aot andrepestana-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sh16011993 sh16011993 merged commit ffb5aa5 into release/v2.3.0 Jan 14, 2025
42 checks passed
@sh16011993 sh16011993 deleted the 4223_student_bridge_match_ppd_status_not_importing branch January 14, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SIMS-Api SIMS-Api
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants