Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4094 - File Issues - Comma in file name (#4153) #4160

Merged
merged 1 commit into from
Dec 20, 2024
Merged

#4094 - File Issues - Comma in file name (#4153) #4160

merged 1 commit into from
Dec 20, 2024

Conversation

bidyashish
Copy link
Collaborator

@bidyashish bidyashish commented Dec 20, 2024 •
edited
Loading

Technical Details

  • Ensure the file name is escaped while downloading to prevent the issue with the comma and some other potential characters.
  • Add an E2E test with some scenarios to test different characters.
  • This should be added to v2.2 branch.

Demo:
Able to Download File with Comma

image

image

@bidyashish
#4094 - File Issues - Comma in file name (#4153)
24a036b 
**Technical Details**
- [x] Ensure the file name is escaped while downloading to prevent the
issue with the comma and some other potential characters.
- [x] Add an E2E test with some scenarios to test different characters.
- [ ] This should be added to v2.2 branch.


Demo:
Able to Download File with Comma

![image](https://github.com/user-attachments/assets/82bd65d5-ed65-41b2-b252-edad13b07fa8)

![image](https://github.com/user-attachments/assets/dca924d4-1e2a-4727-8b70-deab9b95f060)
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 21.94% ( 3786 / 17255 )
Methods: 9.99% ( 219 / 2192 )
Lines: 25.29% ( 3281 / 12971 )
Branches: 13.67% ( 286 / 2092 )

@github-actions GitHub Actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.43% ( 583 / 891 )
Methods: 59.26% ( 64 / 108 )
Lines: 68.54% ( 464 / 677 )
Branches: 51.89% ( 55 / 106 )

@github-actions GitHub Actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 80% ( 1336 / 1670 )
Methods: 63.55% ( 136 / 214 )
Lines: 83.49% ( 1123 / 1345 )
Branches: 69.37% ( 77 / 111 )

@github-actions GitHub Actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 67.4% ( 5922 / 8787 )
Methods: 65.09% ( 729 / 1120 )
Lines: 71.33% ( 4647 / 6515 )
Branches: 47.4% ( 546 / 1152 )

@bidyashish bidyashish self-assigned this Dec 20, 2024
@bidyashish bidyashish added the Branch Sync-up Branch features move between main/release/hotfix branches. label Dec 20, 2024
andrewsignori-aot
andrewsignori-aot approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bidyashish bidyashish merged commit 109657e into release/v2.2.0 Dec 20, 2024
21 checks passed
@bidyashish bidyashish deleted the cherry-pick/#4094-file-comma branch December 20, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsignori-aot andrewsignori-aot andrewsignori-aot approved these changes

Assignees

@bidyashish bidyashish

Labels
Branch Sync-up Branch features move between main/release/hotfix branches.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bidyashish @andrewsignori-aot