#4094 - File Issues - Comma in file name #4153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sources/packages/backend/apps/api/src/route-controllers/student/student.controller.service.ts
Outdated
Show resolved
Hide resolved
dheepak-aot
reviewed
Dec 19, 2024
| response.setHeader( | ||
| "Content-Disposition", | ||
| `attachment; filename=${studentFile.fileName}`, | ||
| `attachment; filename*=UTF-8''${encodedFileName}`, |
There was a problem hiding this comment.
Great finding.
I see that it follows the Extended notation example from RFC5987
I believe the encodeURIComponent() sufficient not required to do further replace as stated here.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/encodeURIComponent#examples
Thoughts ?
@andrewsignori-aot @andrepestana-aot @guru-aot @lewischen-aot
dheepak-aot
reviewed
Dec 19, 2024
| response.setHeader( | ||
| "Content-Disposition", | ||
| `attachment; filename=${studentFile.fileName}`, | ||
| `attachment; filename*=UTF-8''${encodedFileName}`, |
There was a problem hiding this comment.
Please move this logic of creating encoded file name to a common util.
There was a problem hiding this comment.
Moved to String utils
dheepak-aot
reviewed
Dec 19, 2024
| * @returns Object containing encoded filename | ||
| */ | ||
| export function encodeFileNameForContentDisposition(fileName: string): string { | ||
| const encodedFileName = encodeURIComponent(fileName); |
There was a problem hiding this comment.
As we are just using encodeURIComponent please remove the util as the purpose seems to be more linear.
There was a problem hiding this comment.
removed the utils func
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
dheepak-aot
approved these changes
Dec 19, 2024
bidyashish
added a commit
that referenced
this pull request
Dec 20, 2024
**Technical Details** - [x] Ensure the file name is escaped while downloading to prevent the issue with the comma and some other potential characters. - [x] Add an E2E test with some scenarios to test different characters. - [ ] This should be added to v2.2 branch. Demo: Able to Download File with Comma  
bidyashish
added a commit
that referenced
this pull request
Dec 20, 2024
**Technical Details** - [x] Ensure the file name is escaped while downloading to prevent the issue with the comma and some other potential characters. - [x] Add an E2E test with some scenarios to test different characters. - [x] This should be added to v2.2 branch. Demo: Able to Download File with Comma  
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Details
Demo:
Able to Download File with Comma