Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Issues - Comma in file name #4094

Closed
3 tasks
CarlyCotton opened this issue Dec 13, 2024 · 0 comments
Closed
3 tasks

File Issues - Comma in file name #4094

CarlyCotton opened this issue Dec 13, 2024 · 0 comments
Assignees
Labels
Bug Something isn't working

Comments

@CarlyCotton
Copy link
Collaborator

CarlyCotton commented Dec 13, 2024

Description
When a student uploads a file with a comma in the name, it causes issues when trying to download it. The original file name remains the same but we remove commas when creating the unique file name.

Current Behaviour
When a file has been uploaded with a comma in it, that file is unable to be downloaded by any users within SIMS.

Expected Behaviour
We can download files that have successfully had a virus scan.

Steps to reproduce

  1. Upload a file with a comma in the name.
  2. Have the file pass virus scan.
  3. Try to download the file.

Technical Details

  • Ensure the file name is escaped while downloading to prevent the issue with the comma and some other potential characters.
  • Add an E2E test with some scenarios to test different characters.
  • This should be added to v2.2 branch.
@CarlyCotton CarlyCotton added the Business Items under Business Consideration label Dec 13, 2024
@CarlyCotton CarlyCotton self-assigned this Dec 13, 2024
@CarlyCotton CarlyCotton added the Bug Something isn't working label Dec 13, 2024
@Joshua-Lakusta Joshua-Lakusta added Dev & Architecture Development and Architecture and removed Business Items under Business Consideration labels Dec 17, 2024
@andrewsignori-aot andrewsignori-aot removed the Dev & Architecture Development and Architecture label Dec 17, 2024
github-merge-queue bot pushed a commit that referenced this issue Dec 19, 2024
**Technical Details**
- [x] Ensure the file name is escaped while downloading to prevent the
issue with the comma and some other potential characters.
- [x] Add an E2E test with some scenarios to test different characters.
- [ ] This should be added to v2.2 branch.


Demo:
Able to Download File with Comma

![image](https://github.com/user-attachments/assets/82bd65d5-ed65-41b2-b252-edad13b07fa8)

![image](https://github.com/user-attachments/assets/dca924d4-1e2a-4727-8b70-deab9b95f060)
bidyashish added a commit that referenced this issue Dec 20, 2024
**Technical Details**
- [x] Ensure the file name is escaped while downloading to prevent the
issue with the comma and some other potential characters.
- [x] Add an E2E test with some scenarios to test different characters.
- [ ] This should be added to v2.2 branch.


Demo:
Able to Download File with Comma

![image](https://github.com/user-attachments/assets/82bd65d5-ed65-41b2-b252-edad13b07fa8)

![image](https://github.com/user-attachments/assets/dca924d4-1e2a-4727-8b70-deab9b95f060)
bidyashish added a commit that referenced this issue Dec 20, 2024
**Technical Details**
- [x] Ensure the file name is escaped while downloading to prevent the
issue with the comma and some other potential characters.
- [x] Add an E2E test with some scenarios to test different characters.
- [x] This should be added to v2.2 branch.


Demo:
Able to Download File with Comma


![image](https://github.com/user-attachments/assets/82bd65d5-ed65-41b2-b252-edad13b07fa8)


![image](https://github.com/user-attachments/assets/dca924d4-1e2a-4727-8b70-deab9b95f060)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants