-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File Issues - Comma in file name #4094
Labels
Bug
Something isn't working
Comments
github-merge-queue bot
pushed a commit
that referenced
this issue
Dec 19, 2024
**Technical Details** - [x] Ensure the file name is escaped while downloading to prevent the issue with the comma and some other potential characters. - [x] Add an E2E test with some scenarios to test different characters. - [ ] This should be added to v2.2 branch. Demo: Able to Download File with Comma  
bidyashish
added a commit
that referenced
this issue
Dec 20, 2024
**Technical Details** - [x] Ensure the file name is escaped while downloading to prevent the issue with the comma and some other potential characters. - [x] Add an E2E test with some scenarios to test different characters. - [ ] This should be added to v2.2 branch. Demo: Able to Download File with Comma  
bidyashish
added a commit
that referenced
this issue
Dec 20, 2024
**Technical Details** - [x] Ensure the file name is escaped while downloading to prevent the issue with the comma and some other potential characters. - [x] Add an E2E test with some scenarios to test different characters. - [x] This should be added to v2.2 branch. Demo: Able to Download File with Comma  
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
When a student uploads a file with a comma in the name, it causes issues when trying to download it. The original file name remains the same but we remove commas when creating the unique file name.
Current Behaviour
When a file has been uploaded with a comma in it, that file is unable to be downloaded by any users within SIMS.
Expected Behaviour
We can download files that have successfully had a virus scan.
Steps to reproduce
Technical Details
The text was updated successfully, but these errors were encountered: