Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3667 - Reuse Redis Connections #3992

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

andrewsignori-aot
Copy link
Collaborator

During the prior investigation was detected that when all the schedulers try to execute redis operations at the same time it fails after a certain amount of concurrent connections.
The possible solutions being investigated are:

  1. Allow the connection sharing as mentioned here https://github.com/OptimalBits/bull/blob/develop/PATTERNS.md#reusing-redis-connections
  2. Control the service initialization to prevent multiple concurrent connections.

This is PR an attempt to test the first options.

@andrewsignori-aot andrewsignori-aot self-assigned this Nov 22, 2024
@andrewsignori-aot andrewsignori-aot added Bug Something isn't working Queue Consumers labels Nov 22, 2024
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.03% ( 3718 / 16875 )
Methods: 10.17% ( 214 / 2105 )
Lines: 25.36% ( 3226 / 12719 )
Branches: 13.55% ( 278 / 2051 )

Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.43% ( 583 / 891 )
Methods: 59.26% ( 64 / 108 )
Lines: 68.54% ( 464 / 677 )
Branches: 51.89% ( 55 / 106 )

Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 84.17% ( 1234 / 1466 )
Methods: 83.8% ( 119 / 142 )
Lines: 85.44% ( 1050 / 1229 )
Branches: 68.42% ( 65 / 95 )

Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 66.94% ( 5774 / 8625 )
Methods: 64.8% ( 718 / 1108 )
Lines: 70.87% ( 4531 / 6393 )
Branches: 46.71% ( 525 / 1124 )

@andrewsignori-aot andrewsignori-aot marked this pull request as ready for review November 22, 2024 22:41
@dheepak-aot dheepak-aot self-requested a review November 22, 2024 22:56
Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice Work @andrewsignori-aot

Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@andrewsignori-aot andrewsignori-aot added this pull request to the merge queue Nov 22, 2024
Merged via the queue into main with commit 54cb5b9 Nov 22, 2024
20 checks passed
andrewsignori-aot added a commit that referenced this pull request Nov 25, 2024
During the prior investigation was detected that when all the schedulers
try to execute redis operations at the same time it fails after a
certain amount of concurrent connections.
The possible solutions being investigated are:
1. Allow the connection sharing as mentioned here
https://github.com/OptimalBits/bull/blob/develop/PATTERNS.md#reusing-redis-connections
2. Control the service initialization to prevent multiple concurrent
connections.

This is PR an attempt to test the first options.
andrewsignori-aot added a commit that referenced this pull request Nov 25, 2024
During the prior investigation was detected that when all the schedulers
try to execute redis operations at the same time it fails after a
certain amount of concurrent connections.
The possible solutions being investigated are:
1. Allow the connection sharing as mentioned here
https://github.com/OptimalBits/bull/blob/develop/PATTERNS.md#reusing-redis-connections
2. Control the service initialization to prevent multiple concurrent
connections.

This is PR an attempt to test the first options.
andrewsignori-aot added a commit that referenced this pull request Nov 25, 2024
During the prior investigation was detected that when all the schedulers
try to execute redis operations at the same time it fails after a
certain amount of concurrent connections.
The possible solutions being investigated are:
1. Allow the connection sharing as mentioned here
https://github.com/OptimalBits/bull/blob/develop/PATTERNS.md#reusing-redis-connections
2. Control the service initialization to prevent multiple concurrent
connections.

This is PR an attempt to test the first options.
@andrewsignori-aot andrewsignori-aot deleted the investigation/#3667-reuse-redis-connections branch November 25, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Queue Consumers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants