Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3667 - Reuse Redis Connections #3992

Merged
merged 1 commit into from
Nov 22, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 51 additions & 10 deletions sources/packages/backend/libs/services/src/queue/queue.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,34 @@ import { DatabaseModule } from "@sims/sims-db";
})
export class QueueModule {}

/**
* Shared client connection to redis cluster.
* @see https://github.com/OptimalBits/bull/blob/develop/PATTERNS.md#reusing-redis-connections
*/
let sharedClientRedisCluster: Cluster;
/**
* Shared subscriber connection to redis cluster.
* @see https://github.com/OptimalBits/bull/blob/develop/PATTERNS.md#reusing-redis-connections
*/
let sharedSubscriberClientRedisCluster: Cluster;

/**
* Creates a Redis cluster connection.
* @param options the redis connection options.
* @returns a new instance of Redis cluster connection.
*/
function createdRedisClusterConnection(options: RedisOptions): Cluster {
return new Redis.Cluster(
[
{
host: options.host,
port: options.port,
},
],
{ redisOptions: { password: options.password } },
);
}

/**
* Connection factory which returns connection properties
* to connect redis.
Expand All @@ -54,16 +82,29 @@ async function getConnectionFactory(
};
}
return {
createClient: (): Redis | Cluster => {
return new Redis.Cluster(
[
{
host: redisConnectionOptions.host,
port: redisConnectionOptions.port,
},
],
{ redisOptions: { password: redisConnectionOptions.password } },
);
createClient: (
type: "client" | "subscriber" | "bclient",
): Redis | Cluster => {
switch (type) {
case "client":
if (!sharedClientRedisCluster) {
sharedClientRedisCluster = createdRedisClusterConnection(
redisConnectionOptions,
);
}
return sharedClientRedisCluster;
case "subscriber":
if (!sharedSubscriberClientRedisCluster) {
sharedSubscriberClientRedisCluster = createdRedisClusterConnection(
redisConnectionOptions,
);
}
return sharedSubscriberClientRedisCluster;
case "bclient":
// bclient types should always create a new connection.
// @see https://github.com/OptimalBits/bull/blob/develop/PATTERNS.md#reusing-redis-connections
return createdRedisClusterConnection(redisConnectionOptions);
}
},
};
}
Expand Down