Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3840 - Hotfix: Bulk uploads: Unexpected error while uploading the file displays when "Validate" or "Create now" are selected for valid bulk upload #3860

Conversation

andrepestana-aot
Copy link
Collaborator

@andrepestana-aot andrepestana-aot commented Oct 30, 2024

In Vuetify newer versions there's a change on how VFileInput deals with the model value:

  • If multiple prop is undefined or false, VFileInput will return a File. If true, it returns a File[].

Instead of destructuring a file from an array, the model file can be used as the blob required.

@andrepestana-aot andrepestana-aot self-assigned this Oct 30, 2024
@andrepestana-aot andrepestana-aot added the Bug Something isn't working label Oct 30, 2024
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 65.62% ( 5524 / 8418 )
Methods: 63.14% ( 680 / 1077 )
Lines: 69.75% ( 4367 / 6261 )
Branches: 44.17% ( 477 / 1080 )

Copy link

Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 21.9% ( 3495 / 15956 )
Methods: 9.89% ( 197 / 1991 )
Lines: 25.6% ( 3081 / 12036 )
Branches: 11.25% ( 217 / 1929 )

Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 58.64% ( 509 / 868 )
Methods: 52.88% ( 55 / 104 )
Lines: 62.27% ( 411 / 660 )
Branches: 41.35% ( 43 / 104 )

Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 84.49% ( 1035 / 1225 )
Methods: 84.13% ( 106 / 126 )
Lines: 85.59% ( 885 / 1034 )
Branches: 67.69% ( 44 / 65 )

@andrepestana-aot andrepestana-aot added the Institution Institution Features label Oct 30, 2024
@andrepestana-aot andrepestana-aot marked this pull request as ready for review October 30, 2024 23:48
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great finding, looks good 👍

Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice and quick fix @andrepestana-aot

@andrepestana-aot andrepestana-aot merged commit 70b09ee into hotfix/v1.14.1 Oct 31, 2024
18 of 19 checks passed
andrepestana-aot added a commit that referenced this pull request Oct 31, 2024
Same fix done for the bulk upload in
#3860.
@andrepestana-aot andrepestana-aot deleted the 3840_bulk_uploads_unexpected_error_validate_and_create branch November 1, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Institution Institution Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants