Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: Bulk uploads: Unexpected error while uploading the file displays when "Validate" or "Create now" are selected for valid bulk upload #3840

Closed
astridSABC opened this issue Oct 25, 2024 · 0 comments
Assignees
Labels
Ad-hoc Bug Something isn't working Business Items under Business Consideration Institution Institution Features

Comments

@astridSABC
Copy link
Collaborator

astridSABC commented Oct 25, 2024

Describe the Bug
When the user has a valid .csv file, when they click "Validate" or "Create now" there is an unexpected error message displayed

Note: Need to check a file with additional spaces or invalid information

Expected Behaviour
1. Click “Validate”
(error handling)
When the file is validated, if there are any issues with the file an informative message is displayed

Example:
image.png

Click "Validate" (acceptable file)
Confirmation message such as "File is validated, click "Create now" to proceed" or some user friendly message.

2. Click "Create now"
(error handling) - (most likely not selected if *.csv does not validate)

(acceptable file)
Confirmation message such as "Success! Your bulk offerings have been uploaded" or some user friendly message.

Actual Behaviour
Click "Validate" below error message is displayed

Click "Create now" below error message is displayed

image.png

** Steps To Reproduce**
Steps to reproduce the behaviour:

Precondition
Note: The institution location code
A program that allows part time programs with above institution location code in the Institution Program code field and an SABC code
.xls spreadsheet has been filled out and saved as a Comma Delimited (*.csv) format

bulk-offering-upload-template.xlsx

In the test environment and staging (occurs in test and staging)

  1. Login to the institution that has the program that was created from above
  2. Click “Manage Institution” link in the top right pane
  3. Click “Offerings Upload” link in the bottom left corner
  4. Drag your .csv file into the “Offering CSV file” field
  5. Click “Validate” button
  6. Note any messages, if validates goto step 7
  7. Click “Create now” button
@astridSABC astridSABC added Ad-hoc Bug Something isn't working Institution Institution Features Business Items under Business Consideration labels Oct 25, 2024
@andrepestana-aot andrepestana-aot self-assigned this Oct 30, 2024
@ninosamson ninosamson changed the title BUG: Bulk uploads: Unexpected error while uploading the file displays when "Validate" or "Create now" are selected for valid bulk upload Hotfix: Bulk uploads: Unexpected error while uploading the file displays when "Validate" or "Create now" are selected for valid bulk upload Oct 30, 2024
andrepestana-aot added a commit that referenced this issue Oct 31, 2024
…le displays when "Validate" or "Create now" are selected for valid bulk upload (#3860)

In Vuetify newer versions there's a [change on how VFileInput deals with
the model
value](https://vuetifyjs.com/en/api/v-file-input/#props-model-value):
- If `multiple` prop is undefined or false, VFileInput will return a
`File`. If true, it returns a `File[]`.
 
Instead of destructuring a file from an array, the model file can be
used as the blob required.
andrepestana-aot added a commit that referenced this issue Oct 31, 2024
Same fix done for the bulk upload in
#3860.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ad-hoc Bug Something isn't working Business Items under Business Consideration Institution Institution Features
Projects
None yet
Development

No branches or pull requests

3 participants