Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3840 - Hotfix: Fix for withdraw upload #3868

Conversation

andrepestana-aot
Copy link
Collaborator

@andrepestana-aot andrepestana-aot commented Oct 31, 2024

Same fix done for the bulk upload in #3860.

Copy link

Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 21.9% ( 3495 / 15961 )
Methods: 9.89% ( 197 / 1991 )
Lines: 25.59% ( 3081 / 12040 )
Branches: 11.24% ( 217 / 1930 )

Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 58.64% ( 509 / 868 )
Methods: 52.88% ( 55 / 104 )
Lines: 62.27% ( 411 / 660 )
Branches: 41.35% ( 43 / 104 )

@andrepestana-aot andrepestana-aot self-assigned this Oct 31, 2024
@andrepestana-aot andrepestana-aot added Bug Something isn't working Institution Institution Features labels Oct 31, 2024
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 86.09% ( 1058 / 1229 )
Methods: 87.3% ( 110 / 126 )
Lines: 87.08% ( 903 / 1037 )
Branches: 68.18% ( 45 / 66 )

@andrepestana-aot andrepestana-aot marked this pull request as ready for review October 31, 2024 20:59
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 65.62% ( 5524 / 8418 )
Methods: 63.14% ( 680 / 1077 )
Lines: 69.75% ( 4367 / 6261 )
Branches: 44.17% ( 477 / 1080 )

Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of it. Looks good 👍

Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work @andrepestana-aot

@andrepestana-aot andrepestana-aot merged commit d5e0fa3 into hotfix/v1.14.1 Oct 31, 2024
20 checks passed
@andrepestana-aot andrepestana-aot deleted the 3840_bulk_uploads_unexpected_error_withdraw_upload branch October 31, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Institution Institution Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants