-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SFAS-SIMS Bridge File - MSFAA Implementation #3774
Comments
guru-aot
pushed a commit
that referenced
this issue
Oct 22, 2024
guru-aot
pushed a commit
that referenced
this issue
Oct 23, 2024
github-merge-queue bot
pushed a commit
that referenced
this issue
Oct 25, 2024
- [x] Refactored associateMSFAANumber in disbursement.schedule.service.ts as the Cognitive Complexity became 18 so changed for early return during creation or assigning of MSFAA. - [x] During Associate MSFAA, if valid MSFAA number is present for a student, then use it. - [x] Else check for previously signed application disbursement already sent with valid end date and MSFAA number is present, use that. - [x] Else check if SFAS individual MSFAA number is present and checked if the application end date is within validate date, then use the MSFAA and create in SIMS and activate it. - [x] Else If MSFAA is not found in SFAS application, then check if MSFAA number is present in pending state, waiting for signing. - [x] Else create MSFAA number and activate and assign it to the application. - [x] E2E Test cases created for the above scenarios. - [x] Removed a not useful check in the getCurrentValidMSFAANumber method, which has referenceApplication as not null. - [x] The Sonarcloud issue is related to Cognitive Complexity in test helper class, so ignored. --------- Co-authored-by: guru-aot <[email protected]>
@ninosamson bringing this ticket back as there is a pending minor refactor to be executed. |
github-merge-queue bot
pushed a commit
that referenced
this issue
Oct 29, 2024
Refactoring import modules in the SFASIntegrationModule. --------- Co-authored-by: guru-aot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
User Story
As a student, it is possible for me to have two MSFAA numbers (PT and FT). I don't want to have a new one issued by SIMS when I already have a valid one in SFAS/SAIL.
Acceptance Criteria
Business Context
Technical
sims.sfas_individuals
by itsstudent_id
.part_time_msfaa_number
.msfaa_number
.msfaa_number
: from SFAS individual table;date_requested
:null
;date_signed
: date fromstudy_end_date
from the most recent application on SFAS table.service_provider_received_date
:null
;reference_application
: populate with the SIMS application id.options.existingMSFAA
to allow process already in place to consistently keep only one active MSFAA.The text was updated successfully, but these errors were encountered: