Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3774 - Refactoring Import Modules #3853

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Conversation

guru-aot
Copy link
Collaborator

Refactoring import modules in the SFASIntegrationModule.

@andrewsignori-aot andrewsignori-aot changed the title #3774 - Refactoring_Import_Modules #3774 - Refactoring Import Modules Oct 29, 2024
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refactor, please take a look at the comments.

Copy link

Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.35% ( 3692 / 16516 )
Methods: 10.33% ( 212 / 2053 )
Lines: 25.67% ( 3202 / 12475 )
Branches: 13.98% ( 278 / 1988 )

Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.43% ( 583 / 891 )
Methods: 59.26% ( 64 / 108 )
Lines: 68.54% ( 464 / 677 )
Branches: 51.89% ( 55 / 106 )

Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 83.33% ( 1180 / 1416 )
Methods: 84.29% ( 118 / 140 )
Lines: 84.27% ( 1002 / 1189 )
Branches: 68.97% ( 60 / 87 )

Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 66.01% ( 5571 / 8439 )
Methods: 63.3% ( 683 / 1079 )
Lines: 70.12% ( 4401 / 6276 )
Branches: 44.93% ( 487 / 1084 )

Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Copy link
Collaborator

@andrepestana-aot andrepestana-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@guru-aot guru-aot added this pull request to the merge queue Oct 29, 2024
Merged via the queue into main with commit 5b9f09a Oct 29, 2024
20 checks passed
@guru-aot guru-aot deleted the feature/#3774-Import_Refactoring branch October 29, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants