#3774 - SFAS MSFAA Implementation

[guru-aot]

• Refactored associateMSFAANumber in disbursement.schedule.service.ts as the Cognitive Complexity became 18 so changed for early return during creation or assigning of MSFAA.
• During Associate MSFAA, if valid MSFAA number is present for a student, then use it.
• Else check for previously signed application disbursement already sent with valid end date and MSFAA number is present, use that.
• Else check if SFAS individual MSFAA number is present and checked if the application end date is within validate date, then use the MSFAA and create in SIMS and activate it.
• Else If MSFAA is not found in SFAS application, then check if MSFAA number is present in pending state, waiting for signing.
• Else create MSFAA number and activate and assign it to the application.
• E2E Test cases created for the above scenarios.
• Removed a not useful check in the getCurrentValidMSFAANumber method, which has referenceApplication as not null.
• The Sonarcloud issue is related to Cognitive Complexity in test helper class, so ignored.

[andrewsignori-aot]

This method can be invoked with more precise parameters.

[andrewsignori-aot]

Do the parameters need to have the firstDisbursement?
Suggestion:

studentId: number,
applicationId: number,
offeringIntensity: OfferingIntensity,
studyStartDate: string,
auditUserId: number,

[andrewsignori-aot]

Thanks for making the changes and for the effort on the E2E. Please take a look at the remaining comments.

[andrewsignori-aot]

We should validate if those values are the same as the SFAS, right?
Please use the savedSFASPartTimeApplication for asserts.

[andrewsignori-aot]

Thanks for making the changes, great work overall. Looks good 👍

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions]

Backend Unit Tests Coverage Report

Totals
Statements:	22.52% ( 3670 / 16295 )
Methods:	10.15% ( 206 / 2029 )
Lines:	25.9% ( 3186 / 12301 )
Branches:	14.15% ( 278 / 1965 )

[github-actions]

E2E Workflow Workers Coverage Report

Totals
Statements:	65.43% ( 583 / 891 )
Methods:	59.26% ( 64 / 108 )
Lines:	68.54% ( 464 / 677 )
Branches:	51.89% ( 55 / 106 )

[github-actions]

E2E Queue Consumers Coverage Report

Totals
Statements:	83.87% ( 1175 / 1401 )
Methods:	84.29% ( 118 / 140 )
Lines:	84.78% ( 997 / 1176 )
Branches:	70.59% ( 60 / 85 )

[github-actions]

E2E SIMS API Coverage Report

Totals
Statements:	66.01% ( 5571 / 8439 )
Methods:	63.3% ( 683 / 1079 )
Lines:	70.12% ( 4401 / 6276 )
Branches:	44.93% ( 487 / 1084 )

[lewischen-aot]

Looks good to me 👍 Great work @guru-aot That's a lot of E2E tests to make sure the implementation is working.