Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation of DeploymentConfig #3685

Closed
2 tasks done
andrewsignori-aot opened this issue Sep 11, 2024 · 2 comments
Closed
2 tasks done

Deprecation of DeploymentConfig #3685

andrewsignori-aot opened this issue Sep 11, 2024 · 2 comments
Assignees
Labels
Devops Devops Waiting Waiting for other activity, requirement or deliverable before it can be actioned.

Comments

@andrewsignori-aot
Copy link
Collaborator

andrewsignori-aot commented Sep 11, 2024

  • Start with one service and create subsequent tickets for the rest

What is happening?
Plattaform Services Team is upgrading to OCP 4.14 in 2024 Q3. Coming to this new version, the DeploymentConfig object is being deprecated. There is no immediate effect after the upgrade, any existing DeploymentConfig workloads will continue to run, but eventually this feature will be removed in future upgrades. The recommendation is to use Deployment instead of DeploymentConfig.

When?
OCP4.14 upgrade is scheduled for Silver in mid September, Gold and GoldDR in October. After the upgrade, DeploymentConfig objects will be deprecated and you will start to see warning about the use of them. While DeploymentConfigs are still supported, they are not recommended for any new installations. Only security-related and critical issues will be fixed by RedHat. There is no specific timeline on when DeploymentConfig will stop working on OCP yet, but teams should start converting to Deployment now.

Do I need to do anything?
If you are creating new workloads, make sure to use Deployment instead of DeploymentConfig.
If you have existing DeploymentConfig workloads, please follow this RedHat guidance to convert them to Deployment objects.

Technical

  • Pick one of the existing deployments (suggested web-sims) and follow the conversion guide to establish the path to be applied to all other deployments.
  • If time allows, execute the conversion of all deployments. If not, create a ticket to continue the work.
@andrewsignori-aot andrewsignori-aot added the Dev & Architecture Development and Architecture label Sep 11, 2024
@andrewsignori-aot andrewsignori-aot self-assigned this Sep 11, 2024
@andrewsignori-aot andrewsignori-aot added the Devops Devops label Sep 11, 2024
@andrewsignori-aot andrewsignori-aot changed the title DeploymentConfig Conversion to Deployment Deprecation of DeploymentConfig Sep 11, 2024
@andrewsignori-aot andrewsignori-aot added the Waiting Waiting for other activity, requirement or deliverable before it can be actioned. label Oct 11, 2024
@andrewsignori-aot andrewsignori-aot removed the Dev & Architecture Development and Architecture label Dec 17, 2024
@dheepak-aot dheepak-aot assigned dheepak-aot and unassigned bidyashish Jan 3, 2025
@AnnaPBashkatova AnnaPBashkatova added this to the 2.2 Full-Time "Asset" milestone Jan 7, 2025
github-merge-queue bot pushed a commit that referenced this issue Jan 8, 2025
# Convert Deployment Config to Deployment - SIMS Web

## Resource
- [Redhat
Guide](https://developers.redhat.com/learning/learn:openshift:replace-deprecated-deploymentconfigs-deployments/resource/resources:convert-deploymentconfig-deployment?mc_cid=1a844df827&mc_eid=f049851a15)
- [Kubernetes rollout status
command](https://kubernetes.io/docs/reference/kubectl/generated/kubectl_rollout/kubectl_rollout_status/#:~:text=Show%20the%20status%20of%20the,continue%20watching%20the%20latest%20revision.)

![image](https://github.com/user-attachments/assets/770cc1b9-d1f5-4538-85a7-995a4b632c48)


## Updates
- [x] Converted the `DeploymentConfig` object `sims-web` to `Deployment`
- [x] The metadata label `deploymentconfig` is replaced with label
`app`. This label is now used as selector.
- [x] The `HorizontalPodAutoscaler` is now attached to `Deployment`
instead of `DeploymentConfig`.
- [x] The `rollout status` command is now executed on deployment.
github-merge-queue bot pushed a commit that referenced this issue Jan 14, 2025
# Convert the following DC to Deployments

- [x] Queue Consumers
- [x] Workers
- [x] API
- [x] Load Test Gateway
github-merge-queue bot pushed a commit that referenced this issue Jan 17, 2025
…#4256)

## Convert to Deployment

- [x] Convert FormIO DC to deployment

## Update fetch old tags script

- [x] Updated fetch old tags script to get the deployed version of
`image steam` based on deployment instead of DC.

![image](https://github.com/user-attachments/assets/1c861633-6acc-47d6-a708-88e1a91eb3a9)

## Removed the `creationTimestamp` from metadata in form

- [x] Removed `creationTimestamp:null` in metadata from formio objects
as it is not followed in other configs in our application.
@dheepak-aot
Copy link
Collaborator

All the deployment configs are converted to deployment during this implementation.
Also the part fetch old tags to prune has been updated to use deployment to find current deployed image.

@dheepak-aot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Devops Devops Waiting Waiting for other activity, requirement or deliverable before it can be actioned.
Projects
None yet
Development

No branches or pull requests

5 participants