#3685 - Convert FormIO to deployment and update fetch old tags script #4256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
| @@ -511,7 +511,7 @@ deploy-forms: | |||
| -p TLS_KEY=$(TLS_KEY) \ | |||
| -p TLS_CA_CERTIFICATE=$(TLS_CA_CERTIFICATE) \ | |||
| | oc -n $(NAMESPACE) apply -f - | |||
| $(call rollout_and_wait,dc/$(FORMS_NAME)) | |||
| $(call rollout_and_wait,deployment/$(FORMS_NAME)) | |||
| @@ -59,7 +59,8 @@ IS_NAMESPACE="${LICENSE_PLATE}-tools" | |||
| DC_NAME="${ENV}-${APP_NAME}" | |||
|
|
|||
| # Lookup the dc to get the deployed container image tag | |||
| DC_IMAGE=$(oc get dc/$DC_NAME -n $DC_NAMESPACE -o json | jq -r '.spec.template.spec.containers[].image') | |||
| # TODO: Change the naming convention from DC to deployment if required in future. | |||
| DC_IMAGE=$(oc get deployment/$DC_NAME -n $DC_NAMESPACE -o json | jq -r '.spec.template.spec.containers[].image') | |||
There was a problem hiding this comment.
Not a problem: just notice that all the variables start with "DC" 😄
There was a problem hiding this comment.
That is the reason behind adding the TODO comment. 😊
andrepestana-aot
approved these changes
Jan 16, 2025
andrewsignori-aot
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert to Deployment
Update fetch old tags script
image steambased on deployment instead of DC.Removed the
creationTimestampfrom metadata in formcreationTimestamp:nullin metadata from formio objects as it is not followed in other configs in our application.