Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3685 - Convert to Deployment - Part 2 #4231

Merged
merged 4 commits into from
Jan 14, 2025

Conversation

dheepak-aot
Copy link
Collaborator

@dheepak-aot dheepak-aot commented Jan 14, 2025

Convert the following DC to Deployments

  • Queue Consumers
  • Workers
  • API
  • Load Test Gateway

@dheepak-aot dheepak-aot added the Devops Devops label Jan 14, 2025
@dheepak-aot dheepak-aot self-assigned this Jan 14, 2025
@dheepak-aot dheepak-aot marked this pull request as ready for review January 14, 2025 17:18
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.49% ( 3850 / 17122 )
Methods: 10.37% ( 224 / 2161 )
Lines: 25.88% ( 3322 / 12837 )
Branches: 14.31% ( 304 / 2124 )

Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.59% ( 589 / 898 )
Methods: 59.63% ( 65 / 109 )
Lines: 68.72% ( 468 / 681 )
Branches: 51.85% ( 56 / 108 )

Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 86.14% ( 1249 / 1450 )
Methods: 82.42% ( 136 / 165 )
Lines: 88.51% ( 1032 / 1166 )
Branches: 68.07% ( 81 / 119 )

Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 67.77% ( 5992 / 8842 )
Methods: 65.54% ( 738 / 1126 )
Lines: 71.62% ( 4695 / 6555 )
Branches: 48.15% ( 559 / 1161 )

@bidyashish bidyashish self-requested a review January 14, 2025 17:46
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice progress and work, looks good 👍

Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work @dheepak-aot

Copy link
Collaborator

@bidyashish bidyashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dheepak-aot dheepak-aot added this pull request to the merge queue Jan 14, 2025
Merged via the queue into main with commit c9adb4e Jan 14, 2025
21 checks passed
@dheepak-aot dheepak-aot deleted the upgrade/#3685-convert-queue-consumers-to-deployment branch January 14, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Devops Devops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants