-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Business validations for Bulk Withdrawal Upload #2112
Comments
This was referenced Aug 22, 2023
Question
|
sh16011993
added a commit
that referenced
this issue
Nov 1, 2023
sh16011993
added a commit
that referenced
this issue
Nov 8, 2023
## As a part of this PR, the following tasks were completed: - [x] Checked to ensure that the affected Student Application belongs to the institution uploading the file. - [x] In case one or multiple validations failed, the validation errors are returned. Below are the validation criteria: - If the application number is not found, assuming it is an SFAS application, it is just skipped and the rest of the file is processed. A warning is generated to the user: "Application is not present in SIMS and is a part of the SFAS system." - Validated if the combination of the SIN, Application number and institution matched with a record on SIMS. If not, returned the following line as a warning message "The record was not found and will be skipped." - If the file contains a line for an application that already has a withdrawal recorded, returned the line as a warning message: "This application is already withdrawn with the date: [withdrawal date]." - Verified that the application is in "Completed" status and not archived to execute the withdrawal, if not, returned an error with the message "The application is not in the completed status." or "The application is already archived and cannot be withdrawn." - [x] For every single file line that has an error or warning, a summary is displayed: - Line number: record number including the header in the count. - Application Number (even if invalid): displayed to show which "Application Number" was interrupted. - Withdrawal Date (even if invalid): displayed to show the "Withdrawal Date" of the interrupted "Application Number". - Validations: displayed to show a user-friendly message about why the record is not considered valid. - [x] Centralized the error validation code to the `validation-utils` file. ### Screenshots [validation errors and warnings]: <img width="1919" alt="image" src="https://github.com/bcgov/SIMS/assets/7859295/d1c586fd-0e23-4d65-b8ba-472ae146e29f"> ------------------------------------------------------------------------------------------------------------------------------------------ <img width="1919" alt="image" src="https://github.com/bcgov/SIMS/assets/7859295/e47a9861-ce5e-499f-9676-37044ee232c5"> ------------------------------------------------------------------------------------------------------------------------------------------ <img width="1918" alt="image" src="https://github.com/bcgov/SIMS/assets/7859295/00a65201-a240-4337-a5fd-c7ca8febcdc9"> ------------------------------------------------------------------------------------------------------------------------------------------ <img width="1920" alt="image" src="https://github.com/bcgov/SIMS/assets/7859295/7f176c57-cde9-4ab9-9b83-ddff9ea7325f"> ------------------------------------------------------------------------------------------------------------------------------------------ <img width="1920" alt="image" src="https://github.com/bcgov/SIMS/assets/7859295/880628ff-3479-46a9-9947-5db8c958c1b0"> ------------------------------------------------------------------------------------------------------------------------------------------ <img width="1919" alt="image" src="https://github.com/bcgov/SIMS/assets/7859295/82f89661-b0eb-4fa6-9bc5-64ebaa37dd31">
sh16011993
added a commit
that referenced
this issue
Nov 8, 2023
sh16011993
added a commit
that referenced
this issue
Nov 9, 2023
…2490) ### As a part of this PR, the following bug is fixed: **Bug:** UI shows success message in the snackbar when there are validation errors for one or more application bulk withdrawal errors. **Fix:** This is fixed to show no success message when there are one or more validation errors. ### Bug: <img width="1918" alt="image" src="https://github.com/bcgov/SIMS/assets/7859295/a4b95895-4250-4a40-abf4-07a97c0dd1a2"> ### Fix: <img width="1915" alt="image" src="https://github.com/bcgov/SIMS/assets/7859295/4b9a230a-adf0-4b96-bc03-251fc12edac4">
sh16011993
added a commit
that referenced
this issue
Nov 9, 2023
sh16011993
added a commit
that referenced
this issue
Nov 9, 2023
…2491) ## As a part of this PR, the following is fixed: **Bug:** When an application record in the bulk withdrawal file where the student has previously withdrawn from the program (scholastic standing) is processed and the same record in the file also has an incorrect value of SIN: ### The below errors and warnings are shown: <img width="1918" alt="image" src="https://github.com/bcgov/SIMS/assets/7859295/a485250e-395d-4552-8bc1-18f5b43836f2"> ### **[Fix]** Instead the following errors and warnings must be shown: <img width="1920" alt="image" src="https://github.com/bcgov/SIMS/assets/7859295/7df329e7-7660-424b-a2fc-c0f92115508d">
sh16011993
added a commit
that referenced
this issue
Nov 9, 2023
sh16011993
added a commit
that referenced
this issue
Nov 9, 2023
…2493) ### As a part of this PR, the following is fixed: **Bug:** If the application is withdrawn due to the **student withdrew from program (this very specific type of scholastic standing only)**, then the error message resulting from the application getting archived shows up. **[Bug Screenshot]** <img width="1920" alt="image" src="https://github.com/bcgov/SIMS/assets/7859295/ff5bb5ee-dbea-4c09-8d72-847b17fb1e61"> **Fix:** If the application is withdrawn due to student withdrew from program, then the error message resulting from the application getting archived shouldn't be shown. Only the warning message: "This application is already withdrawn and going to be skipped." is shown. As per the new message request in the story, the withdrawal date is also not shown in the UI. **[Fix Screenshot]** The application in the below screenshot has scholastic standing: Student withdrew from program. Hence, only the warning message "This application is already withdrawn and going to be skipped." is shown. <img width="1918" alt="image" src="https://github.com/bcgov/SIMS/assets/7859295/9a2c5b34-f894-473f-be49-bcfc500291e3">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the task
Business validations for Bulk Withdrawal Upload.
Assuming the file parsing and file format validation is already done the dependency ticket https://app.zenhub.com/workspaces/student-information-management-system-5fce9df5aa1b45000e937014/issues/gh/bcgov/sims/2111
Reference figma Design
https://www.figma.com/file/9Om2tzLAVEoMQrjmrH4fhu/MOD-SIMS?type=design&node-id=12566-163067&mode=design&t=LyYYv68zdOfihIDs-0
Additional Context
Acceptance Criteria
originator
in the header of the file. [Confirmed with @HRAGANBC]. If the institution location for a record does not match as per the fileoriginator
field, throw the error "Application number not found. The withdrawal request for this application will not be processed."The text was updated successfully, but these errors were encountered: