-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2112 - Application Bulk Withdrawal: Business Validation - Bug Fix #2493
#2112 - Application Bulk Withdrawal: Business Validation - Bug Fix #2493
Conversation
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM👍 and thanks for the context
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for checking that!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
As a part of this PR, the following is fixed:
Bug: If the application is withdrawn due to the student withdrew from program (this very specific type of scholastic standing only), then the error message resulting from the application getting archived shows up.
[Bug Screenshot]
Fix: If the application is withdrawn due to student withdrew from program, then the error message resulting from the application getting archived shouldn't be shown. Only the warning message: "This application is already withdrawn and going to be skipped." is shown.
As per the new message request in the story, the withdrawal date is also not shown in the UI.
[Fix Screenshot]
The application in the below screenshot has scholastic standing: Student withdrew from program. Hence, only the warning message "This application is already withdrawn and going to be skipped." is shown.