Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2112 - Application Bulk Withdrawal: Business Validation - Bug Fix #2493

Conversation

sh16011993
Copy link
Collaborator

@sh16011993 sh16011993 commented Nov 9, 2023

As a part of this PR, the following is fixed:

Bug: If the application is withdrawn due to the student withdrew from program (this very specific type of scholastic standing only), then the error message resulting from the application getting archived shows up.

[Bug Screenshot]

image

Fix: If the application is withdrawn due to student withdrew from program, then the error message resulting from the application getting archived shouldn't be shown. Only the warning message: "This application is already withdrawn and going to be skipped." is shown.

As per the new message request in the story, the withdrawal date is also not shown in the UI.

[Fix Screenshot]

The application in the below screenshot has scholastic standing: Student withdrew from program. Hence, only the warning message "This application is already withdrawn and going to be skipped." is shown.

image

Copy link

sonarqubecloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

github-actions bot commented Nov 9, 2023

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 19.99% ( 2612 / 13065 )
Methods: 10.43% ( 173 / 1658 )
Lines: 22.78% ( 2252 / 9887 )
Branches: 12.3% ( 187 / 1520 )

Copy link
Contributor

@ann-aot ann-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍 and thanks for the context

Copy link

github-actions bot commented Nov 9, 2023

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 52.62% ( 341 / 648 )
Methods: 50% ( 40 / 80 )
Lines: 56.85% ( 282 / 496 )
Branches: 26.39% ( 19 / 72 )

Copy link

github-actions bot commented Nov 9, 2023

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 76.94% ( 564 / 733 )
Methods: 71.59% ( 63 / 88 )
Lines: 78.75% ( 493 / 626 )
Branches: 42.11% ( 8 / 19 )

Copy link

github-actions bot commented Nov 9, 2023

E2E SIMS API Coverage Report

Totals Coverage
Statements: 55.08% ( 4064 / 7379 )
Methods: 51.98% ( 499 / 960 )
Lines: 59.83% ( 3298 / 5512 )
Branches: 29.44% ( 267 / 907 )

Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Copy link
Collaborator

@andrepestana-aot andrepestana-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for checking that!

Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants