#2112 - Application Bulk Withdrawal: Business Validations - Bug Fix

bcgov · Nov 9, 2023 · 5638400 · 5638400
1 parent 937b182
commit 5638400
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 17 deletions.
diff --git a/...c/services/application-bulk-withdrawal/application-bulk-withdrawal-import-text.service.ts b/...c/services/application-bulk-withdrawal/application-bulk-withdrawal-import-text.service.ts
@@ -177,10 +177,11 @@ export class ApplicationWithdrawalImportTextService {
         textValidation.textModel.applicationNumber;
       validationModel.withdrawalDate = textValidation.textModel.withdrawalDate;
       validationModel.applicationFound = false;
-      if (applicationData) {
+      if (
+        applicationData &&
+        textValidation.textModel.sin === applicationData.sin
+      ) {
         validationModel.applicationFound = true;
-        validationModel.studentSINMatch =
-          textValidation.textModel.sin === applicationData.sin;
         validationModel.isArchived = applicationData.isArchived;
         validationModel.applicationStatus = applicationData.applicationStatus;
         validationModel.hasPreviouslyBeenWithdrawn =

diff --git a/...src/services/application-bulk-withdrawal/application-bulk-withdrawal-validation.models.ts b/...src/services/application-bulk-withdrawal/application-bulk-withdrawal-validation.models.ts
@@ -66,20 +66,6 @@ export class ApplicationBulkWithdrawalValidationModel {
     ),
   })
   applicationFound: boolean;
-  /**
-   * Valid SIN.
-   */
-  @ValidateIf(
-    (object: ApplicationBulkWithdrawalValidationModel) =>
-      object.applicationFound,
-  )
-  @IsIn([true], {
-    message: "The record was not found and will be skipped.",
-    context: ValidationContext.CreateWarning(
-      ApplicationWithdrawalValidationWarnings.NoMatchingRecordFound,
-    ),
-  })
-  studentSINMatch?: boolean;
   /**
    * Application Status.
    */