Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process MSFAA cancellation and reactivation from federal file. #1777

Closed
6 tasks
JasonCTang opened this issue Mar 7, 2023 · 1 comment · Fixed by #2010
Closed
6 tasks

Process MSFAA cancellation and reactivation from federal file. #1777

JasonCTang opened this issue Mar 7, 2023 · 1 comment · Fixed by #2010
Assignees

Comments

@JasonCTang
Copy link
Collaborator

JasonCTang commented Mar 7, 2023

We are already reading the MSFAA cancellation from the federal file, and updating two fields in the database: the cancellation date column and the new issuing province column.

We will need to inform the student that their MSFAA has been cancelled in the interface through notification.

Federal government can also reactivate an existing cancelled MSFAA number. A "reactivated" MSFAA record just looks like the response to a new "received" MSFAA request from Finastra. In other words, this will look like a regular MSFAA record (cancelled date and new issuing province will be null).

When reactivating an MSFAA, update the signed date and null the "cancellation date" column and "new issuing province" column. Then reassociate MSFAA with any disbursements pending ECERT generation. Lastly, cancel any outstanding UNSIGNED MSFAA numbers for the student for the same offering intensity as the reactivated MSFAA (Full vs Part time) by updating the "cancellation date" and leave the "new issuing province" column blank.

As per the conversation with @JasonCTang, MSFAA reactivation template is not required as the federal government will send them notification. Received the following notification template for MSFAA Cancellation:


Template Name: Student - MSFAA cancelled

Subject line of the email: Your MSFAA number has been cancelled – StudentAid BC

Email message:

Hey ((givenNames)) ((lastName)),

Your Master Student Financial Assistance Agreement (MSFAA) has been cancelled by National Student Loan Service Centre (NSLSC).
This will not receive any further funds until your MSFAA is reinstated.

To resolve this issue, contact StudentAid BC by phone at 1-800-561-1818.


This is an automated email. Please do not reply. StudentAid BC is committed to protecting your privacy and personal information. For security reasons we do not include account details in automated notifications.


Additional Context

  • We are already reading the file from Linda.
  • We are already updating the fields.
  • Cancellation message: "Your Master Student Financial Aid Agreement has been cancelled."
  • Reactivation message: "Your previously signed Master Student Financial Aid Agreement has been reactivated."
  • Confirmed that reactivation record just looks like a signed record response.

Acceptance Criteria

  • Confirm that the cancellation date is being checked in the appropriate places to determine if the MSFAA is "cancelled." Modify if necessary.
  • When MSFAA is cancelled and reactivated send notification to student.
  • To reactivate the existing MSFAA, update the signed date and null the "cancellation date" column and "new issuing province" column.
  • When MSFAA is reactivated, reassociate with all disbursements pending ecert generation for the same offering intensity. (Same logic as when a new MSFAA is generated.)
  • When MSFAA is reactivated, Update ANY OTHER active (with null cancellation) MSFAA numbers for the student for the SAME OFFERING INTENSITY by populating the "cancellation date" column and leaving the "new issuing province" column null.
  • Write e2e tests.
@JasonCTang JasonCTang changed the title Process MSFAA cancellation from federal file. Process MSFAA cancellation and reactivation from federal file. Mar 28, 2023
@sh16011993 sh16011993 self-assigned this May 30, 2023
@sh16011993
Copy link
Collaborator

The following were checked to determine if the MSFAA is not "cancelled".

MicrosoftTeams-image.png

MicrosoftTeams-image (1).png

MicrosoftTeams-image (2).png

sh16011993 added a commit that referenced this issue Jun 28, 2023
**The following are addressed as a part of this PR:**

- Confirm that the cancellation date is being checked in the appropriate
places to determine if the MSFAA is "cancelled.". Screenshots added to
the story comments.
- To reactivate the existing MSFAA, update the signed date and null the
"cancellation date" column and "new issuing province" column.
- When MSFAA is reactivated, re-associate with all disbursements pending
ecert generation for the same offering intensity.
- When MSFAA is reactivated, Update ANY OTHER active (with null
cancellation) MSFAA numbers for the student for the SAME OFFERING
INTENSITY by populating the "cancellation date" column and leaving the
"new issuing province" column null.

**Added e2e test to test the following
Full-time-process-response-integration and
Part-time-process-response-integration scenario:**

- Should reactivate a cancelled MSFAA when the same MSFAA is received in
the response file and re-associate this reactivated MSFAA with all
pending disbursements.

**To be done in upcoming PR:**

- When MSFAA is cancelled and reactivated send notification to student.
@sh16011993 sh16011993 reopened this Jun 29, 2023
sh16011993 added a commit that referenced this issue Jun 30, 2023
**As a part of this PR:**

- Created a GC Notify template to send emails when a MSFAA record is
cancelled.
- Updated msfaa-number service to save notifications on MSFAA
cancellation.
- MSFAA reactivation template is not required as the federal government
will send them notification.

Screenshot of the sent notification email:

![image](https://github.com/bcgov/SIMS/assets/7859295/fb71ce15-91bc-490c-9cf7-03bb835998eb)

**To be done in a separate PR:**

- E2E tests for MSFAA Cancellation Notification.

**NOTE:** There is an update in the Acceptance Criteria (point 2) -
MSFAA reactivation template is not required as the federal government
will send them notification. Only MSFAA cancellation notification needs
to be sent.
sh16011993 added a commit that referenced this issue Jul 4, 2023
When the full-time or part-time cancellation record files are received,
the corresponding MSFAA records are cancelled and notification is
persisted in the database.

As a part of this PR, e2e tests are written to validate the
notifications when the MSFAA record gets cancelled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants