#1777 - Process MSFAA Cancellation Notification e2e tests #2069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sh16011993
requested review from
andrepestana-aot,
dheepak-aot,
hellolynn-tbtb,
andrewsignori-aot,
guru-aot,
ann-aot and
JasonCTang
ann-aot
reviewed
Jun 30, 2023
...msfaa-integration/_tests_/msfaa-full-time-process-response-integration.scheduler.e2e-spec.ts
Show resolved
Hide resolved
ann-aot
reviewed
Jun 30, 2023
...msfaa-integration/_tests_/msfaa-full-time-process-response-integration.scheduler.e2e-spec.ts
Outdated
Show resolved
Hide resolved
ann-aot
reviewed
Jun 30, 2023
...msfaa-integration/_tests_/msfaa-part-time-process-response-integration.scheduler.e2e-spec.ts
Show resolved
Hide resolved
ann-aot
reviewed
Jun 30, 2023
...msfaa-integration/_tests_/msfaa-part-time-process-response-integration.scheduler.e2e-spec.ts
Outdated
Show resolved
Hide resolved
...msfaa-integration/_tests_/msfaa-full-time-process-response-integration.scheduler.e2e-spec.ts
Show resolved
Hide resolved
| MSFAA_FULL_TIME_RECEIVE_FILE_WITH_SINGLE_CANCELLATION_RECORD, | ||
| ]); | ||
| // Act | ||
| // Now cancel the MSFAA record. |
There was a problem hiding this comment.
Please remove the "Now" or the entire comment line.
There was a problem hiding this comment.
Was this suggestion accepted? I am not able to see the change.
...msfaa-integration/_tests_/msfaa-full-time-process-response-integration.scheduler.e2e-spec.ts
Outdated
Show resolved
Hide resolved
...msfaa-integration/_tests_/msfaa-part-time-process-response-integration.scheduler.e2e-spec.ts
Outdated
Show resolved
Hide resolved
dheepak-aot
reviewed
Jun 30, 2023
...msfaa-integration/_tests_/msfaa-full-time-process-response-integration.scheduler.e2e-spec.ts
Outdated
Show resolved
Hide resolved
|
Good job! Just have one additional minor comments. Other DEVS have pretty much covered everything. |
| expect(cancelledMSFAARecord.cancelledDate).toBe("2021-11-24"); | ||
| expect(cancelledMSFAARecord.newIssuingProvince).toBe("ON"); | ||
| expect(notification.dateSent).toBe(null); | ||
| expect(notification.messagePayload).toStrictEqual({ |
There was a problem hiding this comment.
Thanks for adding this verification.
@ann-aot @guru-aot @dheepak-aot I believe that we can check the dynamic payload saved also as much as possible as part of the E2Es.
andrewsignori-aot
approved these changes
Jul 4, 2023
ann-aot
reviewed
Jul 4, 2023
| @@ -132,12 +138,15 @@ describe( | |||
| const msfaaIDs = createdMSFAARecords.map((msfaa) => msfaa.id); | |||
| const msfaaUpdatedRecords = await db.msfaaNumber.find({ | |||
| select: { | |||
| id: true, | |||
There was a problem hiding this comment.
Thanks @ann-aot . Removed it.
ann-aot
approved these changes
Jul 4, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Backend Unit Tests Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E SIMS API Coverage Report
|
dheepak-aot
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the full-time or part-time cancellation record files are received, the corresponding MSFAA records are cancelled and notification is persisted in the database.
As a part of this PR, e2e tests are written to validate the notifications when the MSFAA record gets cancelled.